Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3824

TermOrdVal/DocValuesComparator does too much work in compareBottom

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.6, 4.0-ALPHA
    • None
    • None
    • New

    Description

      We now have logic to fall back to by-value comparison, when the bottom
      slot is not from the current reader.

      But this is silly, because if the bottom slot is from a different
      reader, it means the tie-break case is not possible (since the current
      reader didn't have the bottom value), so when the incoming ord equals
      the bottom ord we should always return x > 0.

      I added a new random string sort test case to TestSort...

      I also renamed DocValues.SortedSource.getByValue -> getOrdByValue and
      cleaned up some whitespace.

      Attachments

        1. LUCENE-3824.patch
          29 kB
          Michael McCandless

        Activity

          People

            mikemccand Michael McCandless
            mikemccand Michael McCandless
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: