Lucene - Core
  1. Lucene - Core
  2. LUCENE-3816

FilteredDocIdSet does not handle a case where the inner set iterator is null

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.

      The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

      1. LUCENE-3816.patch
        3 kB
        Uwe Schindler
      2. LUCENE-3816.patch
        0.9 kB
        Shay Banon

        Activity

        Hide
        Shay Banon added a comment -

        Patch attached.

        Show
        Shay Banon added a comment - Patch attached.
        Hide
        Uwe Schindler added a comment -

        Tha nks for reporting this, I will check and commit trunk and 3.x branch!

        Show
        Uwe Schindler added a comment - Tha nks for reporting this, I will check and commit trunk and 3.x branch!
        Hide
        Uwe Schindler added a comment -

        Patch with a new test that verifies this works. Fails without Shay's patch.

        Will commit now.

        Show
        Uwe Schindler added a comment - Patch with a new test that verifies this works. Fails without Shay's patch. Will commit now.
        Hide
        Uwe Schindler added a comment -

        Committed trunk revision: 1292282
        Committed 3.x revision: 1292288

        Thanks Shay!

        Show
        Uwe Schindler added a comment - Committed trunk revision: 1292282 Committed 3.x revision: 1292288 Thanks Shay!

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Shay Banon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development