Lucene - Core
  1. Lucene - Core
  2. LUCENE-3802

Grouping collector that computes grouped facet counts

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/grouping
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff from issue SOLR-2898.

      1. LUCENE-3802.patch
        51 kB
        Martijn van Groningen
      2. LUCENE-3802.patch
        50 kB
        Martijn van Groningen
      3. LUCENE-3802.patch
        41 kB
        Martijn van Groningen
      4. LUCENE-3802.patch
        22 kB
        Martijn van Groningen

        Issue Links

          Activity

          Hide
          Martijn van Groningen added a comment -

          Patch adds a collector that computes grouped facet counts.

          Work to be done:

          • Add random test
          • Also computed grouped facet counts for multivalued fields by using DocTermOrds class to fetch facet values from.
          Show
          Martijn van Groningen added a comment - Patch adds a collector that computes grouped facet counts. Work to be done: Add random test Also computed grouped facet counts for multivalued fields by using DocTermOrds class to fetch facet values from.
          Hide
          Martijn van Groningen added a comment -

          Updated patch. This patch includes a random test for grouped faceting.

          Show
          Martijn van Groningen added a comment - Updated patch. This patch includes a random test for grouped faceting.
          Hide
          Martijn van Groningen added a comment -

          Updated patch.

          • Can group facet on fields containing more than one term per field.
          • Updated some jdocs.

          Almost ready to commit. Just need to fix proper random testing for grouped faceting on multivalued fields.

          Show
          Martijn van Groningen added a comment - Updated patch. Can group facet on fields containing more than one term per field. Updated some jdocs. Almost ready to commit. Just need to fix proper random testing for grouped faceting on multivalued fields.
          Hide
          Martijn van Groningen added a comment -

          Updated patch. Grouped faceting on multivalued fields is now properly tested.

          I think it is ready to be committed!

          Show
          Martijn van Groningen added a comment - Updated patch. Grouped faceting on multivalued fields is now properly tested. I think it is ready to be committed!
          Hide
          Martijn van Groningen added a comment -

          Committed to trunk.

          Show
          Martijn van Groningen added a comment - Committed to trunk.
          Hide
          Steve Rowe added a comment -

          When I run tests from Maven, I get:

          -------------------------------------------------------------------------------
          Test set: org.apache.lucene.search.grouping.AbstractGroupingTestCase
          -------------------------------------------------------------------------------
          Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.046 sec <<< FA
          ILURE!
          initializationError(org.apache.lucene.search.grouping.AbstractGroupingTestCase)
          Time elapsed: 0.003 sec <<< ERROR!

          [...]

          Results :

          Tests in error:
          initializationError(org.apache.lucene.search.grouping.AbstractGroupingTestCase): No runnable methods!

          The Ant build doesn't have this problem.

          I'll add an @Ignore annotation to this class to keep Maven happy.

          Show
          Steve Rowe added a comment - When I run tests from Maven, I get: ------------------------------------------------------------------------------- Test set: org.apache.lucene.search.grouping.AbstractGroupingTestCase ------------------------------------------------------------------------------- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.046 sec <<< FA ILURE! initializationError(org.apache.lucene.search.grouping.AbstractGroupingTestCase) Time elapsed: 0.003 sec <<< ERROR! [...] Results : Tests in error: initializationError(org.apache.lucene.search.grouping.AbstractGroupingTestCase): No runnable methods! The Ant build doesn't have this problem. I'll add an @Ignore annotation to this class to keep Maven happy.

            People

            • Assignee:
              Unassigned
              Reporter:
              Martijn van Groningen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development