Lucene - Core
  1. Lucene - Core
  2. LUCENE-3801

Generify FST shortestPaths() to take a comparator

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.6, 4.0-ALPHA
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: core/FSTs
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Not sure we should do this, it costs 5-10% performance for WFSTSuggester.
      But maybe we can optimize something here, or maybe its just no big deal to us.

      Because in general, this could be pretty powerful, e.g. if you needed to store
      some custom stuff in the suggester, you could use pairoutputs, or whatever.

      And the possibility we might need shortestPaths for other cool things... at the
      least I just wanted to have the patch up here.

      I haven't tested this on pairoutputs... but i've tested it with e.g. FloatOutputs
      and other things and it works fine.

      I tried to minimize the generics violations, there is only 1 (cannot create generic array).

      1. LUCENE-3801.patch
        15 kB
        Robert Muir
      2. LUCENE-3801.patch
        22 kB
        Robert Muir
      3. LUCENE-3801.patch
        23 kB
        Robert Muir
      4. LUCENE-3801.patch
        23 kB
        Robert Muir

        Activity

        Robert Muir created issue -
        Robert Muir made changes -
        Field Original Value New Value
        Attachment LUCENE-3801.patch [ 12515191 ]
        Robert Muir made changes -
        Assignee Robert Muir [ rcmuir ]
        Robert Muir made changes -
        Attachment LUCENE-3801.patch [ 12516824 ]
        Robert Muir made changes -
        Attachment LUCENE-3801.patch [ 12516830 ]
        Robert Muir made changes -
        Attachment LUCENE-3801.patch [ 12516841 ]
        Robert Muir made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.6 [ 12319070 ]
        Fix Version/s 4.0 [ 12314025 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development