Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3801

Generify FST shortestPaths() to take a comparator

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.6, 4.0-ALPHA
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: core/FSTs
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Not sure we should do this, it costs 5-10% performance for WFSTSuggester.
      But maybe we can optimize something here, or maybe its just no big deal to us.

      Because in general, this could be pretty powerful, e.g. if you needed to store
      some custom stuff in the suggester, you could use pairoutputs, or whatever.

      And the possibility we might need shortestPaths for other cool things... at the
      least I just wanted to have the patch up here.

      I haven't tested this on pairoutputs... but i've tested it with e.g. FloatOutputs
      and other things and it works fine.

      I tried to minimize the generics violations, there is only 1 (cannot create generic array).

        Attachments

        1. LUCENE-3801.patch
          15 kB
          Robert Muir
        2. LUCENE-3801.patch
          22 kB
          Robert Muir
        3. LUCENE-3801.patch
          23 kB
          Robert Muir
        4. LUCENE-3801.patch
          23 kB
          Robert Muir

          Activity

            People

            • Assignee:
              rcmuir Robert Muir
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: