[LUCENE-3774] check-legal isn't doing its job

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6, 4.0-ALPHA
• Fix Version/s: 3.6, 4.0-ALPHA
• Component/s: general/build
• Assignee: Dawid Weiss
• Reporter: Steven Rowe
• Created: 11/Feb/12 22:51
• Updated: 28/Aug/22 13:07
• Resolved: 14/Feb/12 08:35

Description

In trunk, the check-legal-lucene ant target is not checking any lucene/contrib/**/lib/ directories; the modules/**/lib/ directories are not being checked; and check-legal-solr can't be checking solr/example/lib/**/*.jar, because there are currently .jar files in there that don't have a license.

These targets are set up to take in a full list of lib/ directories in which to check, but modules move around, and these lists are not being kept up-to-date.

Instead, check-legal-* should run for each module, if the module has a lib/ directory, and it should be specialized for modules that have more than one (solr/core/) or that have a lib/ directory in a non-standard place (lucene/core/).

Issue Links

• is blocked by: SOLR-3123 Missing/incorrectly named license files in example/lib/