[LUCENE-3756] Don't allow IndexWriterConfig setters to chain

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Created: 07/Feb/12 15:59
• Updated: 28/Aug/22 13:07

Description

Spinoff from LUCENE-3736.

I don't like that IndexWriterConfig's setters are chainable; it
results in code in our tests like this:

IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig( TEST_VERSION_CURRENT, new MockAnalyzer(random)).setMaxBufferedDocs(2).setMergePolicy(newLogMergePolicy()));

I think in general we should avoid chaining since it encourages hard
to read code (code is already hard enough to read!).