Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The PayloadProcessorProvider has a broken API, this should be fixed. The current trunk mimics the old behaviour, but not 100%.

      The PayloadProcessorProvider API should return a PayloadProcessor based on the AtomicReader instance that gets merged. As AtomicReader do no longer know the directory they are reside (they could be e.g. FilterIndexReaders, MemoryIndexes,...) a selection by Directory is no longer possible.

      The current code in Lucene trunk mimics the old behavior by doing an instanceof SegmentReader check and then asking for a DirProvider. If something else is merged in, Payload processing is not supported. This should be changed, the old API could be kept backwards compatible by moving the instanceof check in a "convenience class" DirPayloadProcessorProvider, extending PayloadProcessorProvider.

      1. LUCENE-3735.patch
        11 kB
        Uwe Schindler
      2. LUCENE-3735.patch
        9 kB
        Uwe Schindler
      3. LUCENE-3735-3x.patch
        14 kB
        Uwe Schindler

        Activity

        Hide
        Uwe Schindler added a comment -

        The changes should be backported, to allow easy migration.

        Show
        Uwe Schindler added a comment - The changes should be backported, to allow easy migration.
        Hide
        Uwe Schindler added a comment -

        Patch for trunk

        Show
        Uwe Schindler added a comment - Patch for trunk
        Hide
        Robert Muir added a comment -

        I think we should rename the variable in MergeState to match?

        Show
        Robert Muir added a comment - I think we should rename the variable in MergeState to match?
        Hide
        Uwe Schindler added a comment -

        Committed trunk revision: 1239052

        Now adding backwards layer for 3.x...

        Show
        Uwe Schindler added a comment - Committed trunk revision: 1239052 Now adding backwards layer for 3.x...
        Hide
        Uwe Schindler added a comment -

        I also had to fix javadocs in revision: 1239056

        Show
        Uwe Schindler added a comment - I also had to fix javadocs in revision: 1239056
        Hide
        Uwe Schindler added a comment -

        Patch for branch3x.

        Show
        Uwe Schindler added a comment - Patch for branch3x.
        Hide
        Uwe Schindler added a comment -

        Committed 3.x revision: 1239084

        Show
        Uwe Schindler added a comment - Committed 3.x revision: 1239084

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development