Lucene - Core
  1. Lucene - Core
  2. LUCENE-3718

SamplingWrapperTest failure with certain test seed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      Patch Available

      Description

      Build: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/12231/

      1 tests failed.
      REGRESSION: org.apache.lucene.facet.search.SamplingWrapperTest.testCountUsingSamping

      Error Message:
      Results are not the same!

      Stack Trace:
      org.apache.lucene.facet.FacetTestBase$NotSameResultError: Results are not the same!
      at org.apache.lucene.facet.FacetTestBase.assertSameResults(FacetTestBase.java:333)
      at org.apache.lucene.facet.search.sampling.BaseSampleTestTopK.assertSampling(BaseSampleTestTopK.java:104)
      at org.apache.lucene.facet.search.sampling.BaseSampleTestTopK.testCountUsingSamping(BaseSampleTestTopK.java:82)
      at org.apache.lucene.util.LuceneTestCase$3$1.evaluate(LuceneTestCase.java:529)
      at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:165)
      at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:57)

      NOTE: reproduce with: ant test -Dtestcase=SamplingWrapperTest -Dtestmethod=testCountUsingSamping -Dtests.seed=4a5994491f79fc80:-18509d134c89c159:-34f6ecbb32e930f7 -Dtests.multiplier=3 -Dargs="-Dfile.encoding=UTF-8"
      NOTE: test params are: codec=Lucene40: {$facets=PostingsFormat(name=MockRandom), $full_path$=PostingsFormat(name=MockSep), content=Pulsing40(freqCutoff=19 minBlockSize=65 maxBlockSize=209), $payloads$=PostingsFormat(name=Lucene40WithOrds)}, sim=RandomSimilarityProvider(queryNorm=true,coord=true): {$facets=LM Jelinek-Mercer(0.700000), content=DFR I(n)B3(800.0)}, locale=bg, timezone=Asia/Manila

      1. LUCENE-3718.patch
        0.6 kB
        Doron Cohen
      2. LUCENE-3718.patch
        0.5 kB
        Doron Cohen

        Activity

        Hide
        Michael McCandless added a comment -

        Wow nice catch!

        I agree we don't need CHANGES.txt entry for this...

        Show
        Michael McCandless added a comment - Wow nice catch! I agree we don't need CHANGES.txt entry for this...
        Hide
        Doron Cohen added a comment -

        Fixed.

        Show
        Doron Cohen added a comment - Fixed.
        Hide
        Doron Cohen added a comment -

        Fix committed in r1235190 (trunk).
        Added no CHANGES entry - seems to me an overkill here... other opinions?

        Show
        Doron Cohen added a comment - Fix committed in r1235190 (trunk). Added no CHANGES entry - seems to me an overkill here... other opinions?
        Hide
        Robert Muir added a comment -

        +1 to commit. this is a good test

        Show
        Robert Muir added a comment - +1 to commit. this is a good test
        Hide
        Doron Cohen added a comment -

        updated patch with same fix also in AllDocsSegmentDocsEnum.linearScan() (previous patch fixed only LiveDocsSegmentDocsEnum.linearScan()).

        I also verified that this facets test does not fail in 3x with same seed.

        Show
        Doron Cohen added a comment - updated patch with same fix also in AllDocsSegmentDocsEnum.linearScan() (previous patch fixed only LiveDocsSegmentDocsEnum.linearScan()). I also verified that this facets test does not fail in 3x with same seed.
        Hide
        Simon Willnauer added a comment -

        +1 good catch

        Show
        Simon Willnauer added a comment - +1 good catch
        Hide
        Doron Cohen added a comment -

        Attached simple fix to Lucene40PostingsReader: linearScan() should set doc also when returning refill().

        Show
        Doron Cohen added a comment - Attached simple fix to Lucene40PostingsReader: linearScan() should set doc also when returning refill().
        Hide
        Doron Cohen added a comment -

        well this is not a test bug after all, but rather exposing a bug in Lucene40PostingsReader.

        Show
        Doron Cohen added a comment - well this is not a test bug after all, but rather exposing a bug in Lucene40PostingsReader.
        Hide
        Doron Cohen added a comment -

        failure consistently recreated with these parameters.
        It is most likely a test bug, but still annoying.
        Should also rename misspelled method - should be: testCountUsingSampling()

        Show
        Doron Cohen added a comment - failure consistently recreated with these parameters. It is most likely a test bug, but still annoying. Should also rename misspelled method - should be: testCountUsingSampling()

          People

          • Assignee:
            Doron Cohen
            Reporter:
            Doron Cohen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development