Lucene - Core
  1. Lucene - Core
  2. LUCENE-3686

EnhancementsPayloadIterator.getCategoryData(CategoryEnhancement) problematic usage of Object.equals()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      EnhancementsPayloadIterator has an internal list of category enhancemnets, and in getCategoryData(CategoryEnhancement) there is a lookup of the given CategoryEnhancement in the list. In order to make sure this lookup works, CategoryEnhancement must override Object.equals(Object).

        Activity

        Sivan Yogev created issue -
        Hide
        Sivan Yogev added a comment -

        My first Lucene patch

        Show
        Sivan Yogev added a comment - My first Lucene patch
        Sivan Yogev made changes -
        Field Original Value New Value
        Attachment LUCENE-3686.patch [ 12510167 ]
        Sivan Yogev made changes -
        Lucene Fields New [ 10121 ] New,Patch Available [ 10121,10120 ]
        Shai Erera made changes -
        Assignee Shai Erera [ shaie ]
        Hide
        Shai Erera added a comment -

        Patch looks good (many formatting changes though). I added a CHANGES entry under contrib/CHANGES.txt.

        Committed revision 1230429 (3x).
        Committed revision 1230431 (trunk).

        Thanks Sivan !

        Show
        Shai Erera added a comment - Patch looks good (many formatting changes though). I added a CHANGES entry under contrib/CHANGES.txt. Committed revision 1230429 (3x). Committed revision 1230431 (trunk). Thanks Sivan !
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.6 [ 12319070 ]
        Fix Version/s 4.0 [ 12314025 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        22h 49m 1 Shai Erera 12/Jan/12 07:44
        Resolved Resolved Closed Closed
        484d 2h 59m 1 Uwe Schindler 10/May/13 11:43

          People

          • Assignee:
            Shai Erera
            Reporter:
            Sivan Yogev
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development