Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3683

Add @Noisy annotation for uncontrollably noisy tests

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

        /**
         * Annotation for test classes that are uncontrollably loud, and you 
         * only want output if they actually fail, error, or VERBOSE is enabled.
         * @deprecated Fix your test to properly use {@link #VERBOSE} !
         */
        @Documented
        @Deprecated
        @Target(ElementType.TYPE)
        @Retention(RetentionPolicy.RUNTIME)
        public @interface Noisy {}
      

        Activity

        Hide
        thetaphi Uwe Schindler added a comment -

        Lol. Too funny :/

        Show
        thetaphi Uwe Schindler added a comment - Lol. Too funny :/
        Hide
        dweiss Dawid Weiss added a comment -

        Actualy, this is also taken care of as part of LUCENE-3808... The output reporter emits suite summaries and details (stdout/stderr + exceptions) for ONLY these tests that failed. I agree verbose stdout is fairly annoying.

        I'd rather not commit this in to the trunk because it'll make me go through the conflict with the branch... but if you can't live with this then go ahead (I don't like that verbose output either).

        Show
        dweiss Dawid Weiss added a comment - Actualy, this is also taken care of as part of LUCENE-3808 ... The output reporter emits suite summaries and details (stdout/stderr + exceptions) for ONLY these tests that failed. I agree verbose stdout is fairly annoying. I'd rather not commit this in to the trunk because it'll make me go through the conflict with the branch... but if you can't live with this then go ahead (I don't like that verbose output either).
        Hide
        dweiss Dawid Weiss added a comment -

        An example build log from LUCENE-3808. Note that stdout/stderr is emitted for code that resides in @BeforeClass/@AfterClass hooks (and scope); this can be avoided – for these regions there is simply no information wrt the output status (failed, successful).

        Show
        dweiss Dawid Weiss added a comment - An example build log from LUCENE-3808 . Note that stdout/stderr is emitted for code that resides in @BeforeClass/@AfterClass hooks (and scope); this can be avoided – for these regions there is simply no information wrt the output status (failed, successful).
        Hide
        rcmuir Robert Muir added a comment -

        Just feel free to assign this Dawid: its not urgent, and I'm sure there might a cleaner way now than via my patch.

        Show
        rcmuir Robert Muir added a comment - Just feel free to assign this Dawid: its not urgent, and I'm sure there might a cleaner way now than via my patch.
        Hide
        dweiss Dawid Weiss added a comment -

        Re-attaching, cleaned up the headers (machine info, etc.)

        Show
        dweiss Dawid Weiss added a comment - Re-attaching, cleaned up the headers (machine info, etc.)
        Hide
        dweiss Dawid Weiss added a comment -

        Solved by LUCENE-3808?

        Show
        dweiss Dawid Weiss added a comment - Solved by LUCENE-3808 ?

          People

          • Assignee:
            dweiss Dawid Weiss
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development