Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.

      1. LUCENE-3640.patch
        139 kB
        Robert Muir
      2. LUCENE-3640.patch
        139 kB
        Robert Muir

        Activity

        Hide
        Uwe Schindler added a comment -

        +1

        Show
        Uwe Schindler added a comment - +1
        Hide
        Robert Muir added a comment -

        here's a patch... some tests are angry about what i did in LuceneTestCase though.

        Show
        Robert Muir added a comment - here's a patch... some tests are angry about what i did in LuceneTestCase though.
        Hide
        Robert Muir added a comment -

        updated patch: all tests pass.

        I would like to commit soon so the patch does not grow out of date.

        Show
        Robert Muir added a comment - updated patch: all tests pass. I would like to commit soon so the patch does not grow out of date.
        Hide
        Uwe Schindler added a comment -

        The fix for the readerFinishedLister is cool, as the listener gets called for a lot of readers, also those closed during reopen...

        Show
        Uwe Schindler added a comment - The fix for the readerFinishedLister is cool, as the listener gets called for a lot of readers, also those closed during reopen...
        Hide
        Koji Sekiguchi added a comment -

        remove 3.6 tag from Fix Version/s

        Show
        Koji Sekiguchi added a comment - remove 3.6 tag from Fix Version/s
        Hide
        Robert Muir added a comment -

        Should not have been marked for 3.6... in 3.6 you can still open an IndexSearcher over a Directory and it manages the Reader instance in that case (so you should call close).

        I started trying to backport test fixes, but i found 3.x's tests are massively out of sync with trunk, mostly using tons of deprecated APIs. I'll try to see if i can sync up the tests a bit, otherwise backporting in general is going to get difficult.

        Show
        Robert Muir added a comment - Should not have been marked for 3.6... in 3.6 you can still open an IndexSearcher over a Directory and it manages the Reader instance in that case (so you should call close). I started trying to backport test fixes, but i found 3.x's tests are massively out of sync with trunk, mostly using tons of deprecated APIs. I'll try to see if i can sync up the tests a bit, otherwise backporting in general is going to get difficult.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development