[LUCENE-3637] Make IndexReader.decRef() call refCount.decrementAndGet instead of getAndDecrement

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.6, 4.0-ALPHA
• Component/s: core/search
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 11/Dec/11 13:51
• Updated: 28/Aug/22 13:03
• Resolved: 11/Dec/11 18:10

Description

IndexReader.decRef() has this code:

    final int rc = refCount.getAndDecrement();
    if (rc == 1) {

I think it will be clearer if it was written like this:

    final int rc = refCount.decrementAndGet();
    if (rc == 0) {

It's a very simple change, which makes reading the code (at least IMO) easier. Will post a patch shortly.