Lucene - Core
  1. Lucene - Core
  2. LUCENE-3629

Hide storage details for IndexDocValues inside the codec

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.2
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently ValueType exposes a lot of impl. details about how values are stored. However, since those are really impl details we should move those into the codec and decide during indexing which storage variant we are using. (robert convinced me this is the right thing and we should explore it)

      We can basically reduce the ValuesType to

      { Bytes, SortedBytes, FixedInts, Floats, VarInts }

      . The implementation ie. the codec can decide based on how many unique values and if values have all the same size what storage variant it should use. For merging we would need some statistics exposed on the Source ie. how many unique values and if all value have a fixed size to decide what the target "type" is going to be.

      This change would make usage of the API a lot easier and less confusing and at the same time it makes merging and type promotion straight forward since we can decide what type we promote to without loading the IDV provider to get the actual size and compare it.

        Activity

        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Robert Muir made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 4.3 [ 12324143 ]
        Resolution Fixed [ 1 ]
        Robert Muir made changes -
        Fix Version/s 4.3 [ 12324143 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.2 [ 12323899 ]
        Mark Miller made changes -
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 4.1 [ 12321140 ]
        Mark Miller made changes -
        Fix Version/s 5.0 [ 12321663 ]
        Robert Muir made changes -
        Field Original Value New Value
        Fix Version/s 4.1 [ 12321140 ]
        Fix Version/s 4.0 [ 12314025 ]
        Simon Willnauer created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development