[LUCENE-3620] FilterIndexReader does not override all of IndexReader methods

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6, 4.0-ALPHA
• Component/s: core/search
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 06/Dec/11 16:00
• Updated: 28/Aug/22 13:03
• Resolved: 09/Dec/11 10:18

Description

FilterIndexReader does not override all of IndexReader methods. We've hit an error in LUCENE-3573 (and fixed it). So I thought to write a simple test which asserts that FIR overrides all methods of IR (and we can filter our methods that we don't think that it should override). The test is very simple (attached), and it currently fails over these methods:

getRefCount
incRef
tryIncRef
decRef
reopen
reopen
reopen
reopen
clone
numDeletedDocs
document
setNorm
setNorm
termPositions
deleteDocument
deleteDocuments
undeleteAll
getIndexCommit
getUniqueTermCount
getTermInfosIndexDivisor

I didn't yet fix anything in FIR – if you spot a method that you think we should not override and delegate, please comment.

Issue Links

• is a clone of: LUCENE-2436 FilterIndexReader doesn't delegate everything necessary
• is part of: LUCENE-3606 Make IndexReader really read-only in Lucene 4.0