Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3620

FilterIndexReader does not override all of IndexReader methods

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      FilterIndexReader does not override all of IndexReader methods. We've hit an error in LUCENE-3573 (and fixed it). So I thought to write a simple test which asserts that FIR overrides all methods of IR (and we can filter our methods that we don't think that it should override). The test is very simple (attached), and it currently fails over these methods:

      getRefCount
      incRef
      tryIncRef
      decRef
      reopen
      reopen
      reopen
      reopen
      clone
      numDeletedDocs
      document
      setNorm
      setNorm
      termPositions
      deleteDocument
      deleteDocuments
      undeleteAll
      getIndexCommit
      getUniqueTermCount
      getTermInfosIndexDivisor
      

      I didn't yet fix anything in FIR – if you spot a method that you think we should not override and delegate, please comment.

        Attachments

        1. LUCENE-3620.patch
          15 kB
          Shai Erera
        2. LUCENE-3620.patch
          3 kB
          Shai Erera
        3. LUCENE-3620.patch
          2 kB
          Shai Erera
        4. LUCENE-3620-trunk.patch
          2 kB
          Shai Erera

        Issue Links

          Activity

            People

            • Assignee:
              shaie Shai Erera
              Reporter:
              shaie Shai Erera

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment