Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3605

revisit segments.gen sleeping

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.6, 4.0-ALPHA
    • None
    • None
    • New

    Description

      in LUCENE-3601, i worked up a change where we intentionally crash() all un-fsynced files
      in tests to ensure that we are calling sync on files when we should.

      I think this would be nice to do always (and with some fixes all tests pass).

      But this is super-slow sometimes because when we corrupt the unsynced segments.gen, it causes
      SIS.read to take 500ms each time (and in checkindex for some reason we do this twice, which seems wrong).

      I can workaround this for now for tests (just do a partial crash that avoids corrupting the segments.gen),
      but I wanted to create this issue for discussion about the sleeping/non-fsyncing of segments.gen, just
      because i guess its possible someone could hit this slowness.

      Attachments

        1. LUCENE-3605.patch
          7 kB
          Michael McCandless

        Activity

          People

            mikemccand Michael McCandless
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: