Lucene - Core
  1. Lucene - Core
  2. LUCENE-3603

jar-src fails if ${build.dir} does not exist

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Simple fix – make jar-src depend on a target which creates the build.dir. Also, I noticed that build.dir is set in multiple places across our build.xmls, so I'd like to improve that a bit (minor fixes as well).

        Activity

        Hide
        Shai Erera added a comment -

        Committed revs 1207024 and 1207026.

        Show
        Shai Erera added a comment - Committed revs 1207024 and 1207026.
        Hide
        Simon Willnauer added a comment -

        I intend to commit this soon.

        +1 looks good to me

        Show
        Simon Willnauer added a comment - I intend to commit this soon. +1 looks good to me
        Hide
        Shai Erera added a comment -

        Patch fixes jar-src to:

        • not depend on "init", as there's no need to compile anything (saves time)
        • create $ {build.dir}

        I've decided not to modify the build.dir definitions in the other build.xmls for now, as it's more delicate.

        I intend to commit this soon.

        Show
        Shai Erera added a comment - Patch fixes jar-src to: not depend on "init", as there's no need to compile anything (saves time) create $ {build.dir} I've decided not to modify the build.dir definitions in the other build.xmls for now, as it's more delicate. I intend to commit this soon.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development