Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      BytesRef#startsWith & endsWith should be static those are really utilities.

      1. LUCENE-3592.patch
        34 kB
        Simon Willnauer
      2. LUCENE-3592.patch
        40 kB
        Simon Willnauer
      3. LUCENE-3592.patch
        42 kB
        Simon Willnauer

        Activity

        Hide
        Simon Willnauer added a comment -

        here is a patch converting all uses of startsWith & endsWith + javadocs

        Show
        Simon Willnauer added a comment - here is a patch converting all uses of startsWith & endsWith + javadocs
        Hide
        Simon Willnauer added a comment -

        I will commit this later today if nobody objects

        Show
        Simon Willnauer added a comment - I will commit this later today if nobody objects
        Hide
        Robert Muir added a comment -

        maybe these should go in StringHelper? This is where things like bytesDifference() already are.

        Show
        Robert Muir added a comment - maybe these should go in StringHelper? This is where things like bytesDifference() already are.
        Hide
        Simon Willnauer added a comment -

        yeah that is maybe a better place... I think eventually we want to rename StringHelper into BytesRefHelper or something else. Since really all those methods should accept BytesRef instead bytes[]. I will attach a new patch moving it to StringHelper, keeping the name for now.

        Show
        Simon Willnauer added a comment - yeah that is maybe a better place... I think eventually we want to rename StringHelper into BytesRefHelper or something else. Since really all those methods should accept BytesRef instead bytes[]. I will attach a new patch moving it to StringHelper, keeping the name for now.
        Hide
        Simon Willnauer added a comment -

        moving startsWith & endsWith to StringHelper

        Show
        Simon Willnauer added a comment - moving startsWith & endsWith to StringHelper
        Hide
        Simon Willnauer added a comment -

        next iteration cutting over bytesDifference(byte[], int, int, byte[], int, int) to bytesDifference(BytesRef, BytesRef), I think this is ready

        Show
        Simon Willnauer added a comment - next iteration cutting over bytesDifference(byte[], int, int, byte[], int, int) to bytesDifference(BytesRef, BytesRef), I think this is ready
        Hide
        Simon Willnauer added a comment -

        I plan to commit this tomorrow...

        Show
        Simon Willnauer added a comment - I plan to commit this tomorrow...
        Hide
        Simon Willnauer added a comment -

        committed to trunk in revision 1207564

        Show
        Simon Willnauer added a comment - committed to trunk in revision 1207564

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development