Lucene - Core
  1. Lucene - Core
  2. LUCENE-3549

Remove DocumentBuilder interface from facet module


    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: modules/facet
    • Labels:
    • Lucene Fields:
      New, Patch Available


      The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.

      Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.

      More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.

      If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.


        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Shai Erera made changes -
        Field Original Value New Value
        Attachment LUCENE-3549.patch [ 12501779 ]
        Shai Erera created issue -


          • Assignee:
            Shai Erera
            Shai Erera
          • Votes:
            0 Vote for this issue
            0 Start watching this issue


            • Created: