Lucene - Core
  1. Lucene - Core
  2. LUCENE-3549

Remove DocumentBuilder interface from facet module

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.

      Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.

      More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.

      If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.

        Activity

        Hide
        Uwe Schindler added a comment -

        Bulk close after release of 3.5

        Show
        Uwe Schindler added a comment - Bulk close after release of 3.5
        Hide
        Shai Erera added a comment -

        Committed revision 1196471 (3x).
        Committed revision 1196474 (trunk).

        Show
        Shai Erera added a comment - Committed revision 1196471 (3x). Committed revision 1196474 (trunk).
        Hide
        Shai Erera added a comment -

        Patch against 3x (but easy to apply on trunk as well).

        I will commit this soon.

        Show
        Shai Erera added a comment - Patch against 3x (but easy to apply on trunk as well). I will commit this soon.
        Hide
        Uwe Schindler added a comment -

        +1 to remove. Alltogether it looks too much XML DOM tree like [it's only missing DocumentBuilderFactory]

        Show
        Uwe Schindler added a comment - +1 to remove. Alltogether it looks too much XML DOM tree like [it's only missing DocumentBuilderFactory]
        Hide
        Michael McCandless added a comment -

        I think we should just remove it?

        This is really an app-level thing, and I think overkill for Lucene's one usage of it.

        Show
        Michael McCandless added a comment - I think we should just remove it? This is really an app-level thing, and I think overkill for Lucene's one usage of it.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development