Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4, 3.5, 4.0-ALPHA
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken

      1. LUCENE-3548.patch
        3 kB
        Simon Willnauer

        Activity

        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Uwe Schindler added a comment -

        Bulk close after release of 3.5

        Show
        Uwe Schindler added a comment - Bulk close after release of 3.5
        Simon Willnauer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Simon Willnauer added a comment -

        fixed in trunk & backported to 3.x

        Show
        Simon Willnauer added a comment - fixed in trunk & backported to 3.x
        Hide
        Robert Muir added a comment -

        +1 to fixing things one piece at a time... no reason we have to fix it all at once

        Show
        Robert Muir added a comment - +1 to fixing things one piece at a time... no reason we have to fix it all at once
        Hide
        Simon Willnauer added a comment -

        In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef apis

        where all the methods have the same semantics!

        +1 - I think we should fix the append one in 3.x since we released it and its totally broken (who did this again - oh me my fault!)

        Show
        Simon Willnauer added a comment - In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef apis where all the methods have the same semantics! +1 - I think we should fix the append one in 3.x since we released it and its totally broken (who did this again - oh me my fault!)
        Simon Willnauer made changes -
        Attachment LUCENE-3548.patch [ 12501775 ]
        Hide
        Simon Willnauer added a comment -

        here is a patch

        Show
        Simon Willnauer added a comment - here is a patch
        Simon Willnauer made changes -
        Field Original Value New Value
        Assignee Simon Willnauer [ simonw ]
        Hide
        Robert Muir added a comment -

        while we are at it, maybe we should look at LUCENE-3277?

        I listed a few more things there.

        In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef apis
        where all the methods have the same semantics!

        Show
        Robert Muir added a comment - while we are at it, maybe we should look at LUCENE-3277 ? I listed a few more things there. In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef apis where all the methods have the same semantics!
        Simon Willnauer created issue -

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development