Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3495

BlockJoinQuery doesn't implement boost

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.4
    • 3.5, 4.0-ALPHA
    • None
    • None
    • New

    Description

      After reviewing LUCENE-3494, i checked other queries and noticed that BlockJoinQuery currently throws UOE for getBoost and setBoost:

      throw new UnsupportedOperationException("this query cannot support boosting; please use childQuery.setBoost instead");
      

      I don't think we can safely do that in queries, because other parts of lucene rely upon this working... for example BQs rewrite when
      it has a single clause and erases itself.

      So I think we should just pass down the boost to the inner weight.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rcmuir Robert Muir
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment