Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4, 4.0-ALPHA
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      For the parent issue, and() and andNot() on DISIs and other FixedBitSets are missing. This issue will add those methods.

      The DISI methods (also the already existing or(DISI)) method will check for OpenBitSetIterator and do an inplace operation using the bits as optimization.

      1. LUCENE-3448.patch
        4 kB
        Uwe Schindler
      2. LUCENE-3448.patch
        4 kB
        Uwe Schindler
      3. LUCENE-3448-fix-optimization.patch
        1 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment - - edited

          Patch.

          Show
          Uwe Schindler added a comment - - edited Patch.
          Hide
          Uwe Schindler added a comment -

          I opened LUCENE-3449 because of a stupidness with nextSetBit().

          Show
          Uwe Schindler added a comment - I opened LUCENE-3449 because of a stupidness with nextSetBit().
          Hide
          Uwe Schindler added a comment -

          Updated patch, some improvements. Also limit DISI to numBits

          Show
          Uwe Schindler added a comment - Updated patch, some improvements. Also limit DISI to numBits
          Hide
          Michael McCandless added a comment -

          Patch looks good Uwe!

          Show
          Michael McCandless added a comment - Patch looks good Uwe!
          Hide
          Uwe Schindler added a comment -

          Committed trunk revision: 1174377

          Show
          Uwe Schindler added a comment - Committed trunk revision: 1174377
          Hide
          Uwe Schindler added a comment -

          Committed missing tests in trunk revision: 1174407

          Show
          Uwe Schindler added a comment - Committed missing tests in trunk revision: 1174407
          Hide
          Uwe Schindler added a comment -

          Backported to 3.x branch revision: 1174418

          Show
          Uwe Schindler added a comment - Backported to 3.x branch revision: 1174418
          Hide
          Uwe Schindler added a comment -

          This patch fixes the optimized OpenBitSetIterator and/or/andNot methods to correctly exhaust the iterator after applying the underlying bits.

          Show
          Uwe Schindler added a comment - This patch fixes the optimized OpenBitSetIterator and/or/andNot methods to correctly exhaust the iterator after applying the underlying bits.
          Hide
          Uwe Schindler added a comment -

          Committed fix in trunk revision: 1204416
          Committed fix in 3.x revision: 1204419

          Show
          Uwe Schindler added a comment - Committed fix in trunk revision: 1204416 Committed fix in 3.x revision: 1204419
          Hide
          Uwe Schindler added a comment -

          Bulk close after release of 3.5

          Show
          Uwe Schindler added a comment - Bulk close after release of 3.5

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development