Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Many tests use assertEquals methods which have been deprecated. The culprits are assertEquals(float, float), assertEquals(double, double) and assertEquals(Object[], Object[]). Although not a big issue, they annoy me every time I see them so I'm going to fix them.

      1. LUCENE-3410-remove-asserts.patch
        2 kB
        Chris Male
      2. LUCENE-3419.patch
        29 kB
        Chris Male

        Activity

        Hide
        Chris Male added a comment -

        Patch which adds appropriate epsilons to the float and double assertions and converts array assertions to assertArrayEquals.

        Everything passes.

        Once this is committed, I want to nuke the deprecated assert* methods from LuceneTestCase, as they're no longer used.

        Show
        Chris Male added a comment - Patch which adds appropriate epsilons to the float and double assertions and converts array assertions to assertArrayEquals. Everything passes. Once this is committed, I want to nuke the deprecated assert* methods from LuceneTestCase, as they're no longer used.
        Hide
        Michael McCandless added a comment -

        Yay, nice cleanup!

        Show
        Michael McCandless added a comment - Yay, nice cleanup!
        Hide
        Chris Male added a comment -

        Committed revision 1166582.

        Show
        Chris Male added a comment - Committed revision 1166582.
        Hide
        Chris Male added a comment -

        Trivial patch which removes the deprecated assertEquals methods from LuceneTestCase.

        Show
        Chris Male added a comment - Trivial patch which removes the deprecated assertEquals methods from LuceneTestCase.
        Hide
        Chris Male added a comment -

        Committed revision 1167468.

        Show
        Chris Male added a comment - Committed revision 1167468.
        Hide
        Chris Male added a comment -

        Reopening for 3x backport

        Show
        Chris Male added a comment - Reopening for 3x backport
        Hide
        Chris Male added a comment -

        3x backport:

        Committed revision 1167511.

        Show
        Chris Male added a comment - 3x backport: Committed revision 1167511.
        Hide
        Uwe Schindler added a comment -

        Bulk close after release of 3.5

        Show
        Uwe Schindler added a comment - Bulk close after release of 3.5

          People

          • Assignee:
            Chris Male
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development