Lucene - Core
  1. Lucene - Core
  2. LUCENE-3406

Add source packaging targets that make a tarball from a local working copy

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3, 4.0-ALPHA
    • Fix Version/s: 3.4, 4.0-ALPHA
    • Component/s: general/build
    • Labels:
    • Lucene Fields:
      New, Patch Available

      Description

      I am adding back targets that were removed in <https://issues.apache.org/jira/browse/LUCENE-2973> that are used to create source distribution packaging from a local working copy as new Ant targets.

      2 things to note about the patch:
      1) For package-local-src-tgz in solr/build.xml, I had to specify additional directories under solr/ that have been added since LUCENE-2973.
      2) I couldn't get the package-tgz-local-src in lucene/build.xml to generate the docs folder, which does get added by package-tgz-src.

      The patch is against the trunk.

      1. LUCENE-3406.patch
        5 kB
        Steve Rowe
      2. LUCENE-3406.patch
        4 kB
        Steve Rowe
      3. LUCENE-3406.patch
        4 kB
        Seung-Yeoul Yang

        Activity

        Hide
        Steve Rowe added a comment -

        Committed to trunk and branch_3x.

        Thanks Seung-Yeoul!

        Show
        Steve Rowe added a comment - Committed to trunk and branch_3x. Thanks Seung-Yeoul!
        Hide
        Steve Rowe added a comment -

        This version of the patch makes a couple of small changes to the Solr exclude pattern (adding **/pom.xml and excluding **/*.iws and **/*.ipr; these two IntelliJ config files are not used by the setup provided by ant idea), and adds CHANGES.txt entries for Solr and Lucene.

        I will commit shortly to trunk, then backport to branch_3x.

        Show
        Steve Rowe added a comment - This version of the patch makes a couple of small changes to the Solr exclude pattern (adding **/pom.xml and excluding **/*.iws and **/*.ipr ; these two IntelliJ config files are not used by the setup provided by ant idea ), and adds CHANGES.txt entries for Solr and Lucene. I will commit shortly to trunk, then backport to branch_3x.
        Hide
        Seung-Yeoul Yang added a comment -

        I've tested both targets locally, and they work fine.

        Thanks Steve!

        Show
        Seung-Yeoul Yang added a comment - I've tested both targets locally, and they work fine. Thanks Steve!
        Hide
        Steve Rowe added a comment -

        Hi Seung-Yeoul,

        Here is a new patch with a few changes:

        1. I have cleaned up and simplified the inclusion and exclusion patterns, and moved the lucene patternset to lucene/common-build.xml, which is included in solr/build.xml, so that the pattern only has to be defined once.
        2. I moved the destination file from dist/ to build/, and removed the make-checksums calls, because these targets do not produce ASF distributions.
        3. I renamed the Lucene target to be the same as the Solr target: package-local-src-tgz.

        I have not tried yet, but the resulting packages should build - could you give that a try?

        Show
        Steve Rowe added a comment - Hi Seung-Yeoul, Here is a new patch with a few changes: I have cleaned up and simplified the inclusion and exclusion patterns, and moved the lucene patternset to lucene/common-build.xml , which is included in solr/build.xml , so that the pattern only has to be defined once. I moved the destination file from dist/ to build/ , and removed the make-checksums calls, because these targets do not produce ASF distributions. I renamed the Lucene target to be the same as the Solr target: package-local-src-tgz . I have not tried yet, but the resulting packages should build - could you give that a try?

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Seung-Yeoul Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development