Details

    • Lucene Fields:
      New

      Description

      Steps:
      1. Decide if MockLMSimilarity is needed at all (we have LMDirichletSimilarity)
      2. Move the classes to the similarities package
      3. Move the similarities package to src/
      4. Move all sims (inc. Similarity) to similarities
      5. Make MockBM25Similarity a subclass of EasySimilarity?

      1. LUCENE-3386.patch
        9 kB
        David Mark Nemeskey
      2. LUCENE-3386.patch
        26 kB
        David Mark Nemeskey
      3. LUCENE-3386.patch
        26 kB
        David Mark Nemeskey
      4. LUCENE-3386.patch
        182 kB
        David Mark Nemeskey
      5. LUCENE-3386.patch
        194 kB
        David Mark Nemeskey

        Activity

        Hide
        Robert Muir added a comment -

        Thanks David, good thorough refactor here

        Show
        Robert Muir added a comment - Thanks David, good thorough refactor here
        Hide
        David Mark Nemeskey added a comment -

        I decided agains step 5, at least for now, so I propose we resolve this issue.

        Show
        David Mark Nemeskey added a comment - I decided agains step 5, at least for now, so I propose we resolve this issue.
        Hide
        David Mark Nemeskey added a comment -

        Moved all sims to similarities.

        Show
        David Mark Nemeskey added a comment - Moved all sims to similarities.
        Hide
        David Mark Nemeskey added a comment - - edited

        Moved the similarities package to src; only testing-related classes remain in test.

        Show
        David Mark Nemeskey added a comment - - edited Moved the similarities package to src; only testing-related classes remain in test.
        Hide
        David Mark Nemeskey added a comment -

        Apparently mv doesn't refactor the code. Who would have thought...?

        Show
        David Mark Nemeskey added a comment - Apparently mv doesn't refactor the code. Who would have thought...?
        Hide
        David Mark Nemeskey added a comment -

        Renamed MockBM25Similarity and its provider to BM25... and moved them to the similarities package. All that's left is to decide whether they should be rebased on EasySimilarity or not.

        Show
        David Mark Nemeskey added a comment - Renamed MockBM25Similarity and its provider to BM25... and moved them to the similarities package. All that's left is to decide whether they should be rebased on EasySimilarity or not.
        Hide
        David Mark Nemeskey added a comment -

        Removed MockLMSimilarity and its provider.

        Show
        David Mark Nemeskey added a comment - Removed MockLMSimilarity and its provider.

          People

          • Assignee:
            David Mark Nemeskey
            Reporter:
            David Mark Nemeskey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4h
              4h
              Remaining:
              Remaining Estimate - 4h
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development