Lucene - Core
  1. Lucene - Core
  2. LUCENE-3368

IndexWriter commits update documents without corresponding delete

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0, 3.0.1, 3.0.2, 3.0.3, 3.1, 3.2, 3.3
    • Fix Version/s: 3.4
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      while backporting the testcase from LUCENE-3348 I ran into this thread hazard in the 3.x branch. We actually fixed this issue in LUCENE-3348 for Lucene 4.0 but since DWPT has a slightly different behavior when committing segments I create a new issue to track this down in 3.x. when we prepare a commit we sync on IW flush the DW and apply all deletes then release the lock, maybeMerge and start the commit (IW#startCommit(userdata)). Yet, a new segment could be flushed via getReader and sneak into the SegementInfos which are cloned in IW#startCommit instead of in prepareCommit right after the flush.

      1. LUCENE-3368.patch
        7 kB
        Simon Willnauer

        Activity

        Hide
        Simon Willnauer added a comment -

        here is a patch that clones && commits the SIS while syncing on IW. All test pass including the TestStressNRT running2400 iterations

        Show
        Simon Willnauer added a comment - here is a patch that clones && commits the SIS while syncing on IW. All test pass including the TestStressNRT running2400 iterations
        Hide
        Simon Willnauer added a comment -

        fixed in 3.x

        Show
        Simon Willnauer added a comment - fixed in 3.x
        Hide
        Michael McCandless added a comment -

        Nice catch Simon!

        Show
        Michael McCandless added a comment - Nice catch Simon!

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development