Lucene - Core
  1. Lucene - Core
  2. LUCENE-3329

Maven artifact for lucene-test-framework is identical to lucene-core artifact

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4, 4.0-ALPHA
    • Fix Version/s: 3.4, 4.0-ALPHA
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      No released version of the lucene-test-framework jar is affected.

      This bug was introduced by SOLR-2452. In the m2-deploy macro in lucene/common-build.xml, the names of jar files to deploy were previously drawn from the supplied POM, but since Solr's non-Maven jars don't follow the Maven naming scheme (apache- is prepended), the jar file name now defaults to ${final.name}.jar. Since lucene-test-framework artifacts are built by the base lucene module, ${final.name} is lucene-core-${version}, so when ant generate-maven-artifacts goes to copy the lucene-test-framework binary jar, it grabs the lucene-core binary jar instead.

        Activity

        Steve Rowe created issue -
        Hide
        Steve Rowe added a comment -

        Here's the patch:

        Index: lucene/build.xml
        ===================================================================
        --- lucene/build.xml    (revision 1148712)
        +++ lucene/build.xml    (working copy)
        @@ -410,7 +410,8 @@
                           classifier="javadoc"/>
                 </artifact-attachments>
               </m2-deploy>
        -      <m2-deploy pom.xml="src/test-framework/pom.xml">
        +      <m2-deploy pom.xml="src/test-framework/pom.xml"
        +                 jar.file="${build.dir}/lucene-test-framework-${version}.jar">
                 <artifact-attachments>
                   <attach file="${build.dir}/lucene-test-framework-${version}-src.jar"
                           classifier="sources"/>
        

        Committing shortly.

        Show
        Steve Rowe added a comment - Here's the patch: Index: lucene/build.xml =================================================================== --- lucene/build.xml (revision 1148712) +++ lucene/build.xml (working copy) @@ -410,7 +410,8 @@ classifier= "javadoc" /> </artifact-attachments> </m2-deploy> - <m2-deploy pom.xml= "src/test-framework/pom.xml" > + <m2-deploy pom.xml= "src/test-framework/pom.xml" + jar.file= "${build.dir}/lucene-test-framework-${version}.jar" > <artifact-attachments> <attach file= "${build.dir}/lucene-test-framework-${version}-src.jar" classifier= "sources" /> Committing shortly.
        Hide
        Steve Rowe added a comment -

        Committed:

        • r1148728: trunk
        • r1148731: branch_3x
        Show
        Steve Rowe added a comment - Committed: r1148728: trunk r1148731: branch_3x
        Steve Rowe made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Steven Rowe [ steve_rowe ]
        Fix Version/s 3.4 [ 12316675 ]
        Fix Version/s 4.0 [ 12314025 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development