Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources.

      As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be used by both Solr and other modules. However I don't think they belong in Lucene core, since they aren't really related to search functionality. Therefore I think we should put them into a Common module, which can serve as a dependency to Solr and any module.

      1. LUCENE-3232.patch
        50 kB
        Chris Male
      2. LUCENE-3232.patch
        37 kB
        Chris Male
      3. LUCENE-3232.patch
        55 kB
        Chris Male

        Activity

        Chris Male created issue -
        Chris Male made changes -
        Field Original Value New Value
        Fix Version/s 4.0 [ 12314025 ]
        Chris Male made changes -
        Component/s core/search [ 12310235 ]
        Chris Male made changes -
        Attachment LUCENE-3232.patch [ 12483539 ]
        Chris Male made changes -
        Summary Move MutableValues to Queries Module Move MutableValues to Common Module
        Chris Male made changes -
        Description Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources.

        I'll also use this issue to establish the Queries module where the FunctionQueries will lie.
        Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources.

        As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be used by both Solr and other modules. However I don't think they belong in Lucene core, since they aren't really related to search functionality. Therefore I think we should put them into a Common module, which can serve as a dependency to Solr and any module.
        Chris Male made changes -
        Attachment LUCENE-3232.patch [ 12483544 ]
        Chris Male made changes -
        Attachment LUCENE-3232.patch [ 12483794 ]
        Chris Male made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Chris Male [ cmale ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Chris Male
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development