Lucene - Core
  1. Lucene - Core
  2. LUCENE-3204

Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3, 4.0-ALPHA
    • Fix Version/s: 3.3, 4.0-ALPHA
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Currently, running ant generate-maven-artifacts requires the user to have maven-ant-tasks-*.jar in their Ant classpath, e.g. in ~/.ant/lib/. The build should instead rely on a copy of this jar included in the source tree.

      1. LUCENE-3204.patch
        17 kB
        Steve Rowe
      2. LUCENE-3204.patch
        21 kB
        Steve Rowe

        Activity

        Hide
        Robert Muir added a comment -

        bulk close for 3.3

        Show
        Robert Muir added a comment - bulk close for 3.3
        Hide
        Steve Rowe added a comment -

        Committed:

        • trunk: r1135801, r1135818, r1135822, r1135825
        • branch_3x: r1135827
        Show
        Steve Rowe added a comment - Committed: trunk: r1135801, r1135818, r1135822, r1135825 branch_3x: r1135827
        Hide
        Steve Rowe added a comment -

        Jenkins now complains because of missing license file: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/8840/console

        It's the NOTICE file that's missing, and I've just added it.

        On Jenkins, I removed maven-ant-tasks from ~hudson/.ant/lib.

        Thanks!

        Show
        Steve Rowe added a comment - Jenkins now complains because of missing license file: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/8840/console It's the NOTICE file that's missing, and I've just added it. On Jenkins, I removed maven-ant-tasks from ~hudson/.ant/lib. Thanks!
        Hide
        Uwe Schindler added a comment -

        Jenkins now complains because of missing license file: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/8840/console

        On Jenkins, I removed maven-ant-tasks from ~hudson/.ant/lib.

        Show
        Uwe Schindler added a comment - Jenkins now complains because of missing license file: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/8840/console On Jenkins, I removed maven-ant-tasks from ~hudson/.ant/lib.
        Hide
        Steve Rowe added a comment -

        Added CHANGES.txt entries, including mention of the fact that copies of the maven-ant-tasks jar in the Ant classpath take precedence over the copy in the Lucene/Solr source tree.

        Committing shortly.

        Show
        Steve Rowe added a comment - Added CHANGES.txt entries, including mention of the fact that copies of the maven-ant-tasks jar in the Ant classpath take precedence over the copy in the Lucene/Solr source tree. Committing shortly.
        Hide
        Steve Rowe added a comment -

        I unpacked the jar, defaced the definitions file loaded by the <taskdef>: org/apache/maven/artifact/ant/antlib.xml, then repacked the now-mangled jar and put the result in ~/.ant/lib/, while leaving intact the copy under lucene/lib/.

        The result: the mangled copy under /.ant/lib/ is visited first, resulting in an error. This means that the supplied version does not get preferred over what's already in /.ant/lib/.

        I don't think this is a serious problem, but I'll make mention of it in the CHANGES.txt entry (to be included in another iteration of the patch).

        Show
        Steve Rowe added a comment - I unpacked the jar, defaced the definitions file loaded by the <taskdef>: org/apache/maven/artifact/ant/antlib.xml , then repacked the now-mangled jar and put the result in ~/.ant/lib/ , while leaving intact the copy under lucene/lib/ . The result: the mangled copy under /.ant/lib/ is visited first, resulting in an error. This means that the supplied version does not get preferred over what's already in /.ant/lib/ . I don't think this is a serious problem, but I'll make mention of it in the CHANGES.txt entry (to be included in another iteration of the patch).
        Hide
        Steve Rowe added a comment -

        Does the supplied version of maven-ant-task automatically get preferred over whats already in ~/.ant/lib ?

        I'm not sure. How can I test this? I removed the copy in lucene/lib/ and put a copy of the jar in ~/.ant/lib/. ant generate-maven-artifacts still succeeds.

        Show
        Steve Rowe added a comment - Does the supplied version of maven-ant-task automatically get preferred over whats already in ~/.ant/lib ? I'm not sure. How can I test this? I removed the copy in lucene/lib/ and put a copy of the jar in ~/.ant/lib/ . ant generate-maven-artifacts still succeeds.
        Hide
        Uwe Schindler added a comment -

        I think that's fine. Does the supplied version of maven-ant-task automatically get preferred over whats already in ~/.ant/lib ?

        Show
        Uwe Schindler added a comment - I think that's fine. Does the supplied version of maven-ant-task automatically get preferred over whats already in ~/.ant/lib ?
        Hide
        Steve Rowe added a comment -

        Committing shortly.

        Show
        Steve Rowe added a comment - Committing shortly.
        Hide
        Steve Rowe added a comment -

        Patch implementing the idea.

        Show
        Steve Rowe added a comment - Patch implementing the idea.

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development