Lucene - Core
  1. Lucene - Core
  2. LUCENE-3202

Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3, 4.0-ALPHA
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Such classes would be handy for FST serialization/deserialization.

      1. LUCENE-3202.patch
        5 kB
        Dawid Weiss
      2. LUCENE-3202.patch
        7 kB
        Dawid Weiss

        Activity

        Hide
        Dawid Weiss added a comment - - edited

        A patch moving these stream delegation classes to org.apache.lucene.store. A potential bugfix is piggybacked (potential partial read(byte[]) was not handled correctly).

        Show
        Dawid Weiss added a comment - - edited A patch moving these stream delegation classes to org.apache.lucene.store. A potential bugfix is piggybacked (potential partial read(byte[]) was not handled correctly).
        Hide
        Shai Erera added a comment -

        Patch looks good. Two comments:

        1. The files are missing the Apache License header.
        2. In some places you use this.is / this.out and others just is/out. Can you consolidate on one (I prefer w/o this.)?
        Show
        Shai Erera added a comment - Patch looks good. Two comments: The files are missing the Apache License header. In some places you use this.is / this.out and others just is/out. Can you consolidate on one (I prefer w/o this.)?
        Hide
        Robert Muir added a comment -

        I agree with moving these to .store package, sorry I forgot about this in the suggest refactoring.

        I've had to write similar classes myself before since they were not there.

        Show
        Robert Muir added a comment - I agree with moving these to .store package, sorry I forgot about this in the suggest refactoring. I've had to write similar classes myself before since they were not there.
        Hide
        Dawid Weiss added a comment -

        Thanks Shai. I'll add the headers, clean up this where applicable and commit in.

        Show
        Dawid Weiss added a comment - Thanks Shai. I'll add the headers, clean up this where applicable and commit in.
        Hide
        Dawid Weiss added a comment -

        Updated patch, applied.

        Show
        Dawid Weiss added a comment - Updated patch, applied.
        Hide
        Robert Muir added a comment -

        bulk close for 3.3

        Show
        Robert Muir added a comment - bulk close for 3.3

          People

          • Assignee:
            Dawid Weiss
            Reporter:
            Dawid Weiss
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development