Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: core/store
-
Labels:None
-
Lucene Fields:New
Description
Consistently in my NRT testing on Fedora 13 Linux, 64 bit JVM (Oracle 1.6.0_21) I see MMapDir getting better search and merge performance when compared to NIOFSDir.
I think we should fix the default.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 3.3 [ 12316470 ] | |
| Fix Version/s | 4.0 [ 12314025 ] | |
| Component/s | core/store [ 12310236 ] |
why jump the gun, we can just enable it for linux/64-bit.
if others like freebsd or macos X are tested, then we add those to the list, but mmap is a little bit scary to just apply as a blanket default?
in all cases it should be like the current logic: if (XYZ_OS && 64_bit && UNMAP_SUPPORTED)
Thats fine, I just wanted to talk about the whole issue what to enable when and bring together all possible platform possibilities. In general we should per default only enable SimpleFSDirectory on unknown platforms. Maybe NIO is heavily broken on OS XY (Android lol)?
OK I cutover just Linux, 64 bit, when unmap is available.
We can open new issues for other platforms when we have some data that MMap is better...
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
bulk close for 3.3
| Status | Resolved [ 5 ] | Closed [ 6 ] |
That means we can now enable MMap for all 64 bit platforms? Solaris, windows, Linux - any others except FreeBSD? FreeBSD needs to be checked, but I assume its also faster there. We can check on lucene.zones maybe.