Lucene - Core
  1. Lucene - Core
  2. LUCENE-3165

prepare-release fails if run from source package

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3, 4.0-ALPHA
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      While checking 3.2 RC2 artifacts, I ran "ant prepare-release" and it failed because "get-svn-info" failed (since this is not a svn checkout). This makes sense indeed, but still annoying, so question is how to overcome it? It attempts to execute "svn info" as part of "package-tgz-src". When you run the latter to prepare the release, you want it to fail if "svn" does not exist, however in the source package there's no '.svn' so it cannot succeed.

      On the other hand, nobody should "prepare a release" from the source package, so perhaps the failure is ok, and we should disable the Ant target?

      I don't know how to solve it yet, so I'm marking it as a Blocker for 3.3, so that we at least revisit it before then.

        Activity

        Hide
        Robert Muir added a comment -

        bulk close for 3.3

        Show
        Robert Muir added a comment - bulk close for 3.3
        Hide
        Robert Muir added a comment -

        Committed revision 1129694 (trunk), 1129695 (branch_3x)

        Show
        Robert Muir added a comment - Committed revision 1129694 (trunk), 1129695 (branch_3x)
        Hide
        Shai Erera added a comment -

        Thanks for the education folks !

        +1 to commit.

        Show
        Shai Erera added a comment - Thanks for the education folks ! +1 to commit.
        Hide
        Robert Muir added a comment -

        I would prefer to change this to 'a subversion checkout' before committing, i think this is easier to read based on comments here.

        Show
        Robert Muir added a comment - I would prefer to change this to 'a subversion checkout' before committing, i think this is easier to read based on comments here.
        Hide
        Uwe Schindler added a comment -

        One comment, but I'm not a native English speaker - is it correct to say "AN svn checkout ..." instead of "A svn checkout ..."?

        a / an depends on the sound not the letter the following word starts with. For this reason its "a (j)uniform" not "an (j)uniform". As SVN is here pronounced as "es vi en", it is "an SVN checkout".

        Show
        Uwe Schindler added a comment - One comment, but I'm not a native English speaker - is it correct to say "AN svn checkout ..." instead of "A svn checkout ..."? a / an depends on the sound not the letter the following word starts with. For this reason its "a (j)uniform" not "an (j)uniform". As SVN is here pronounced as "es vi en", it is "an SVN checkout".
        Hide
        Robert Muir added a comment -

        One comment, but I'm not a native English speaker - is it correct to say "AN svn checkout ..." instead of "A svn checkout ..."?

        Its confusing really, when to use 'a' or 'an' depends actually upon whether the word starts with a vowel sound instead of a vowel letter. So you would say 'This test failed in an hourly build yesterday', but you would say 'I bought a horse yesterday'

        http://en.wikipedia.org/wiki/A_and_an#Indefinite_article

        Show
        Robert Muir added a comment - One comment, but I'm not a native English speaker - is it correct to say "AN svn checkout ..." instead of "A svn checkout ..."? Its confusing really, when to use 'a' or 'an' depends actually upon whether the word starts with a vowel sound instead of a vowel letter. So you would say 'This test failed in an hourly build yesterday', but you would say 'I bought a horse yesterday' http://en.wikipedia.org/wiki/A_and_an#Indefinite_article
        Hide
        Shai Erera added a comment -

        Patch looks good. I've applied it to the 3.2.RC2 source package and it fails nicely and clearly. One comment, but I'm not a native English speaker - is it correct to say "AN svn checkout ..." instead of "A svn checkout ..."?

        Show
        Shai Erera added a comment - Patch looks good. I've applied it to the 3.2.RC2 source package and it fails nicely and clearly. One comment, but I'm not a native English speaker - is it correct to say "AN svn checkout ..." instead of "A svn checkout ..."?
        Hide
        Robert Muir added a comment -

        note: with this solution you can still build the binary release from the source release, if you use 'ant package-all-binary'.

        but 'ant prepare-release, ant package-tgz-src, etc' will properly fail, because they try to build a source release.
        and building a source release from a source release is not possible without an svn version number anyway, and not useful

        Show
        Robert Muir added a comment - note: with this solution you can still build the binary release from the source release, if you use 'ant package-all-binary'. but 'ant prepare-release, ant package-tgz-src, etc' will properly fail, because they try to build a source release. and building a source release from a source release is not possible without an svn version number anyway, and not useful
        Hide
        Steve Rowe added a comment -

        attached is a patch: this adds a dependency task 'check-svn' to the 'get-svn-info' task: this way any ant targets that need svn instead will fail with 'An svn checkout is required for this target'

        +1

        Show
        Steve Rowe added a comment - attached is a patch: this adds a dependency task 'check-svn' to the 'get-svn-info' task: this way any ant targets that need svn instead will fail with 'An svn checkout is required for this target' +1
        Hide
        Robert Muir added a comment -

        attached is a patch: this adds a dependency task 'check-svn' to the 'get-svn-info' task: this way any ant targets that need svn instead will fail with 'An svn checkout is required for this target'

        Show
        Robert Muir added a comment - attached is a patch: this adds a dependency task 'check-svn' to the 'get-svn-info' task: this way any ant targets that need svn instead will fail with 'An svn checkout is required for this target'
        Hide
        Robert Muir added a comment -

        On the other hand, nobody should "prepare a release" from the source package, so perhaps the failure is ok, and we should disable the Ant target?

        After re-thinking, if you want to 'build a release' from the source package, how will it know where to get the stuff to do the svn export without a revision number (for the source distribution). So I think we should figure out to make the thing fail, but then fix LUCENE-3166

        Show
        Robert Muir added a comment - On the other hand, nobody should "prepare a release" from the source package, so perhaps the failure is ok, and we should disable the Ant target? After re-thinking, if you want to 'build a release' from the source package, how will it know where to get the stuff to do the svn export without a revision number (for the source distribution). So I think we should figure out to make the thing fail, but then fix LUCENE-3166

          People

          • Assignee:
            Robert Muir
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development