Lucene - Core
  1. Lucene - Core
  2. LUCENE-3150

Wherever we catch & suppress Throwable we should not suppress ThreadInterruptedException

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.9, 5.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In various places we catch Throwable and suppress it, usually in exception handlers where we want to just throw the first exc we had hit.

      But this is dangerous for a thread interrupt since it means we can swallow & ignore the interrupt.

      We should at least catch the interrupt & restore the interrupt bit, if we can't rethrow it.

      One example is in SegmentInfos where we write the segments.gen file... there are many other examples in SegmentInfos too.

      1. LUCENE-3150.patch
        17 kB
        Simon Willnauer

        Activity

        Michael McCandless created issue -
        Robert Muir made changes -
        Field Original Value New Value
        Fix Version/s 3.4 [ 12316675 ]
        Fix Version/s 3.3 [ 12316470 ]
        Michael McCandless made changes -
        Fix Version/s 3.5 [ 12317877 ]
        Fix Version/s 3.4 [ 12316675 ]
        Simon Willnauer made changes -
        Attachment LUCENE-3150.patch [ 12503531 ]
        Simon Willnauer made changes -
        Fix Version/s 3.6 [ 12319070 ]
        Fix Version/s 3.5 [ 12317877 ]
        Hoss Man made changes -
        Fix Version/s 3.6 [ 12319070 ]
        Robert Muir made changes -
        Fix Version/s 4.1 [ 12321140 ]
        Fix Version/s 4.0 [ 12314025 ]
        Mark Miller made changes -
        Fix Version/s 5.0 [ 12321663 ]
        Mark Miller made changes -
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 4.1 [ 12321140 ]
        Robert Muir made changes -
        Fix Version/s 4.3 [ 12324143 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.2 [ 12323899 ]
        Uwe Schindler made changes -
        Fix Version/s 4.4 [ 12324323 ]
        Fix Version/s 4.3 [ 12324143 ]
        Steve Rowe made changes -
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.5 [ 12324742 ]
        Fix Version/s 4.4 [ 12324323 ]
        Adrien Grand made changes -
        Fix Version/s 4.6 [ 12324999 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.5 [ 12324742 ]
        Simon Willnauer made changes -
        Fix Version/s 4.7 [ 12325572 ]
        Fix Version/s 4.6 [ 12324999 ]
        David Smiley made changes -
        Fix Version/s 4.8 [ 12326269 ]
        Fix Version/s 4.7 [ 12325572 ]
        Uwe Schindler made changes -
        Fix Version/s 4.9 [ 12326730 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.8 [ 12326269 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development