Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3147

MockDirectoryWrapper should track open file handles of IndexOutput too

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.2, 4.0-ALPHA
    • general/test
    • None
    • New, Patch Available

    Description

      MockDirectoryWrapper currently tracks open file handles of IndexInput only. Therefore IO files that are not closed do not fail our tests, which can then lead to test directories fail to delete on Windows. We should make sure all open files are tracked and if they are left open, fail the test. I'll attach a patch shortly.

      Attachments

        1. LUCENE-3147.patch
          6 kB
          Shai Erera
        2. LUCENE-3147.patch
          10 kB
          Shai Erera
        3. LUCENE-3147.patch
          28 kB
          Shai Erera
        4. LUCENE-3147.patch
          47 kB
          Shai Erera
        5. LUCENE-3147.patch
          60 kB
          Shai Erera
        6. LUCENE-3147.patch
          62 kB
          Robert Muir
        7. LUCENE-3147.patch
          61 kB
          Michael McCandless
        8. LUCENE-3147.patch
          68 kB
          Michael McCandless
        9. LUCENE-3147.patch
          70 kB
          Simon Willnauer
        10. LUCENE-3147.patch
          85 kB
          Robert Muir
        11. LUCENE-3147.patch
          81 kB
          Shai Erera
        12. LUCENE-3147.patch
          84 kB
          Robert Muir
        13. LUCENE-3147.patch
          84 kB
          Shai Erera
        14. LUCENE-3147-3x.patch
          56 kB
          Shai Erera

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shaie Shai Erera
            shaie Shai Erera
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment