Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE-3140.patch
      233 kB
      Michael McCandless
    2. LUCENE-3140.patch
      242 kB
      Michael McCandless

      Activity

      Hide
      Michael McCandless added a comment -

      Initial patch. TestFSTs passes...

      I pulled back DataInput/Output too.

      Lucene backwards tests failed because IO.copyBytes changed from IndexInput to DataInput...

      Show
      Michael McCandless added a comment - Initial patch. TestFSTs passes... I pulled back DataInput/Output too. Lucene backwards tests failed because IO.copyBytes changed from IndexInput to DataInput...
      Hide
      Robert Muir added a comment -

      Here's just some random stuff I thought about/noticed, some of it only vaguely to this issue:

      • should we name the thing o.a.l.u.fst in trunk too?
      • if FST is going to go into 3.x i think we should do a check to ensure all classes are @experimental
      • I think we should consider cutting Builder over to the new CharsRef?
      • we need to discuss things like autosuggest file formats, etc? At least so we are all on the same page wrt any backwards policy...
      Show
      Robert Muir added a comment - Here's just some random stuff I thought about/noticed, some of it only vaguely to this issue: should we name the thing o.a.l.u.fst in trunk too? if FST is going to go into 3.x i think we should do a check to ensure all classes are @experimental I think we should consider cutting Builder over to the new CharsRef? we need to discuss things like autosuggest file formats, etc? At least so we are all on the same page wrt any backwards policy...
      Hide
      Michael McCandless added a comment -

      should we name the thing o.a.l.u.fst in trunk too?

      Good idea... I'll do that w/ this issue.

      if FST is going to go into 3.x i think we should do a check to ensure all classes are @experimental

      OK will do... there were a few missing (I'll fix trunk too).

      I think we should consider cutting Builder over to the new CharsRef?

      I agree but I think we should do this separately? I'll open an issue...

      we need to discuss things like autosuggest file formats, etc? At least so we are all on the same page wrt any backwards policy...

      Yes... maybe the same policy as the index? So if you create auto-suggest FST in 3.x, 4.x's suggest module will be able to read it / use it?

      The FST itself is already versioned (uses CodecUtil to read/write the header) so we should be all set to impl whatever policy we work out.

      Show
      Michael McCandless added a comment - should we name the thing o.a.l.u.fst in trunk too? Good idea... I'll do that w/ this issue. if FST is going to go into 3.x i think we should do a check to ensure all classes are @experimental OK will do... there were a few missing (I'll fix trunk too). I think we should consider cutting Builder over to the new CharsRef? I agree but I think we should do this separately? I'll open an issue... we need to discuss things like autosuggest file formats, etc? At least so we are all on the same page wrt any backwards policy... Yes... maybe the same policy as the index? So if you create auto-suggest FST in 3.x, 4.x's suggest module will be able to read it / use it? The FST itself is already versioned (uses CodecUtil to read/write the header) so we should be all set to impl whatever policy we work out.
      Hide
      Michael McCandless added a comment -

      New patch for 3.x. I think it's ready to commit.

      I advertised the break of IndexOutput.copyBytes (1st arg now takes DataInput not IndexInput), and remove the backwards test cases that broke from this.

      I also added in missing @experimental tags.

      Show
      Michael McCandless added a comment - New patch for 3.x. I think it's ready to commit. I advertised the break of IndexOutput.copyBytes (1st arg now takes DataInput not IndexInput), and remove the backwards test cases that broke from this. I also added in missing @experimental tags.
      Hide
      Michael McCandless added a comment -

      Committed to 3.x. I still need to move fst under oal.util for trunk...

      Show
      Michael McCandless added a comment - Committed to 3.x. I still need to move fst under oal.util for trunk...
      Hide
      Robert Muir added a comment -

      bulk close for 3.3

      Show
      Robert Muir added a comment - bulk close for 3.3

        People

        • Assignee:
          Michael McCandless
          Reporter:
          Michael McCandless
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development