Lucene - Core
  1. Lucene - Core
  2. LUCENE-3034

If you vary a setting per round and that setting is a long string, the report padding/columns break down.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.9, master
    • Component/s: modules/benchmark
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      This is especially noticeable if you vary a setting where the value is a fully specified class name - in this case, it would be nice if columns in each row still lined up.

        Activity

        Uwe Schindler made changes -
        Fix Version/s 4.9 [ 12326730 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.8 [ 12326269 ]
        Hide
        Uwe Schindler added a comment -

        Move issue to Lucene 4.9.

        Show
        Uwe Schindler added a comment - Move issue to Lucene 4.9.
        David Smiley made changes -
        Fix Version/s 4.8 [ 12326269 ]
        Fix Version/s 4.7 [ 12325572 ]
        Simon Willnauer made changes -
        Fix Version/s 4.7 [ 12325572 ]
        Fix Version/s 4.6 [ 12324999 ]
        Adrien Grand made changes -
        Fix Version/s 4.6 [ 12324999 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.5 [ 12324742 ]
        Steve Rowe made changes -
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.5 [ 12324742 ]
        Fix Version/s 4.4 [ 12324323 ]
        Hide
        Steve Rowe added a comment -

        Bulk move 4.4 issues to 4.5 and 5.0

        Show
        Steve Rowe added a comment - Bulk move 4.4 issues to 4.5 and 5.0
        Uwe Schindler made changes -
        Fix Version/s 4.4 [ 12324323 ]
        Fix Version/s 4.3 [ 12324143 ]
        Robert Muir made changes -
        Fix Version/s 4.3 [ 12324143 ]
        Fix Version/s 4.2 [ 12323899 ]
        Steve Rowe made changes -
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 4.1 [ 12321140 ]
        Robert Muir made changes -
        Fix Version/s 4.1 [ 12321140 ]
        Fix Version/s 4.0 [ 12314025 ]
        Mark Miller made changes -
        Fix Version/s 3.6 [ 12319070 ]
        Hide
        Mark Miller added a comment -

        yeah, this is def not that important. Lets move to 4.

        Show
        Mark Miller added a comment - yeah, this is def not that important. Lets move to 4.
        Hide
        Robert Muir added a comment -

        Mark, are you planning on working on this one? Is it ok to defer until 4.0?

        Show
        Robert Muir added a comment - Mark, are you planning on working on this one? Is it ok to defer until 4.0?
        Mark Miller made changes -
        Field Original Value New Value
        Fix Version/s 3.6 [ 12319070 ]
        Fix Version/s 3.1.1 [ 12316256 ]
        Hide
        Doron Cohen added a comment -

        My original workaround was to simply pad the column name

        Yeah that's what I meant, so ok, better formatting will help.

        Show
        Doron Cohen added a comment - My original workaround was to simply pad the column name Yeah that's what I meant, so ok, better formatting will help.
        Hide
        Mark Miller added a comment -

        Hey Doron - I have a patch for this, I've just been too lazy to extract it. I'm not sure if there is anything built-in that is long enough to matter - it comes into play if, for example, if you want to alternate fully qualified class names per round.

        My original workaround was to simply pad the column name - but it was ugly and had it's limitations, so I instead made some modifications to the formatting classes.

        Show
        Mark Miller added a comment - Hey Doron - I have a patch for this, I've just been too lazy to extract it. I'm not sure if there is anything built-in that is long enough to matter - it comes into play if, for example, if you want to alternate fully qualified class names per round. My original workaround was to simply pad the column name - but it was ugly and had it's limitations, so I instead made some modifications to the formatting classes.
        Hide
        Doron Cohen added a comment -

        Hi Mark, could you add an example algorithm with this behavior?

        Also, this is from the package javadocs:

        # multi val params are iterated by NewRound's, added to reports, start with column name.
        merge.factor=mrg:10:20
        max.buffered=buf:100:1000
        

        Is it possible to workaround the problem by specifying a sufficiently long column name as the first value, that is, replacing e.g. 'mrg' or 'buf' in the above?

        Show
        Doron Cohen added a comment - Hi Mark, could you add an example algorithm with this behavior? Also, this is from the package javadocs: # multi val params are iterated by NewRound's, added to reports, start with column name. merge.factor=mrg:10:20 max.buffered=buf:100:1000 Is it possible to workaround the problem by specifying a sufficiently long column name as the first value, that is, replacing e.g. 'mrg' or 'buf' in the above?
        Mark Miller created issue -

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development