Lucene - Core
  1. Lucene - Core
  2. LUCENE-3012

if you use setNorm, lucene writes a headerless separate norms file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      In this case SR.reWrite just writes the bytes with no header...
      we should write it always.

      we can detect in these cases (segment written <= 3.1) with a
      sketchy length == maxDoc check.

      1. LUCENE-3012_3x.patch
        2 kB
        Robert Muir
      2. LUCENE-3012.patch
        1 kB
        Robert Muir

        Issue Links

          Activity

          Hide
          Robert Muir added a comment -

          Bulk closing for 3.2

          Show
          Robert Muir added a comment - Bulk closing for 3.2
          Hide
          Robert Muir added a comment -

          Committed revision 1124366, 1124369

          Show
          Robert Muir added a comment - Committed revision 1124366, 1124369
          Hide
          Michael McCandless added a comment -

          I agree this is important to fix!

          Patch looks good.

          Show
          Michael McCandless added a comment - I agree this is important to fix! Patch looks good.
          Hide
          Robert Muir added a comment -

          Updated patch (against branch_3x for simplicity) that uses the LUCENE-3014 comparator API.

          Because separate norms files are independent of the version that created the segment (e.g. one can call setNorm with 3.6 for a 3.1 segment), I think its really important that we fix this in 3.2 to write the header.

          If there are no objections, I'd like to commit, and then regenerate the tentative 3.2 indexes for trunk's TestBackwardsCompatibility.

          There's no need to change the fileformats.html documentation, as what we are doing now is actually inconsistent with it, thus the bug.

          Show
          Robert Muir added a comment - Updated patch (against branch_3x for simplicity) that uses the LUCENE-3014 comparator API. Because separate norms files are independent of the version that created the segment (e.g. one can call setNorm with 3.6 for a 3.1 segment), I think its really important that we fix this in 3.2 to write the header. If there are no objections, I'd like to commit, and then regenerate the tentative 3.2 indexes for trunk's TestBackwardsCompatibility. There's no need to change the fileformats.html documentation, as what we are doing now is actually inconsistent with it, thus the bug.
          Hide
          Robert Muir added a comment -

          changing fix version to 3.2, especially given LUCENE-3014

          Show
          Robert Muir added a comment - changing fix version to 3.2, especially given LUCENE-3014

            People

            • Assignee:
              Robert Muir
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development