Lucene - Core
  1. Lucene - Core
  2. LUCENE-3002

Add tests.iter.min to improve controlling tests.iter's behavior

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2, 4.0-ALPHA
    • Component/s: general/test
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      As discussed here: http://lucene.472066.n3.nabble.com/Stop-iterating-if-testsFailed-td2747426.html, this issue proposes to add tests.iter.min in order to allow one better control over how many iterations are run:

      • Keep tests.iter as it is today
      • Add tests.iter.min (default to tests.iter) to denote that at least N instances of the test should run until there's either a failure or tests.iter is reached.

      If one wants to run until the first failure, he can set tests.iter.min=1 and tests.iter=X – up to X instances of the test will run, until the first failure.

      Similarly, one can set tests.iter=N to denote that at least N instances should run, regardless if there were failures, but if after N runs a failure occurred, the test should stop.

      Note: unlike what's proposed on the thread, tests.iter.max is dropped from this proposal as it's exactly like tests.iter, so no point in having two similar parameters.

      I will work on a patch tomorrow.

        Activity

        Hide
        Shai Erera added a comment -

        Patch (3x) adds 'tests.iter.min' which allows stop iterating if at least N instances ran and there was a failure. The last failed iteration is printed.

        Show
        Shai Erera added a comment - Patch (3x) adds 'tests.iter.min' which allows stop iterating if at least N instances ran and there was a failure. The last failed iteration is printed.
        Hide
        Shai Erera added a comment -

        Since it's a trivial change, I plan to commit this either later today or tomorrow.

        Show
        Shai Erera added a comment - Since it's a trivial change, I plan to commit this either later today or tomorrow.
        Hide
        Robert Muir added a comment -

        I took a glance, looks good to me!

        Show
        Robert Muir added a comment - I took a glance, looks good to me!
        Hide
        Shai Erera added a comment -

        Committed revision 1087033 (3x).
        Committed revision 1087036 (trunk).

        Show
        Shai Erera added a comment - Committed revision 1087033 (3x). Committed revision 1087036 (trunk).
        Hide
        Robert Muir added a comment -

        Bulk closing for 3.2

        Show
        Robert Muir added a comment - Bulk closing for 3.2

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development