Lucene - Core
  1. Lucene - Core
  2. LUCENE-2966

SegmentReader.doCommit should be sync'd; norms methods need not be sync'd

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I fixed the failure in TestNRTThreads, but in the process tripped an assert because SegmentReader.doCommit isn't sync'd.

      So I sync'd it, but I don't think the norms APIs need to be sync'd – we populate norms up front and then never change them. Un-sync'ing them is important so that in the NRT case calling IW.commit doesn't block searches trying to pull norms.

      Also some small code refactoring.

      1. LUCENE-2966.patch
        3 kB
        Michael McCandless

        Activity

        Robert Muir made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Michael McCandless made changes -
        Fix Version/s 3.2 [ 12316070 ]
        Fix Version/s 3.1 [ 12314822 ]
        Michael McCandless made changes -
        Field Original Value New Value
        Attachment LUCENE-2966.patch [ 12473482 ]
        Michael McCandless created issue -

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development