Lucene - Core
  1. Lucene - Core
  2. LUCENE-2926

The "init" target in contrib-build.xml should cause the lucene-core jar to be created

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.1, 4.0-ALPHA
    • Fix Version/s: None
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      It would be helpful (e.g. for simplifying the demo contrib build: LUCENE-2923) if the contribs/modules could depend on the up-to-date existence of the lucene-core jar.

      1. LUCENE-2926.patch
        2 kB
        Steve Rowe
      2. LUCENE-2926.patch
        1 kB
        Steve Rowe

        Activity

        Hide
        Steve Rowe added a comment -

        Reverted: trunk rev. 1072009, branch_3x rev. 1072010.

        Show
        Steve Rowe added a comment - Reverted: trunk rev. 1072009, branch_3x rev. 1072010.
        Hide
        Steve Rowe added a comment -

        Would it be not enough to just extend "init" target in the demo contrib? ... [O]n my laptop the build now takes lot longer. ... So contrib/demo is the only one that needs the JAR.

        Yes, it would be enough. I'll revert and include the demo-contrib-specific build changes in LUCENE-2923.

        Show
        Steve Rowe added a comment - Would it be not enough to just extend "init" target in the demo contrib? ... [O] n my laptop the build now takes lot longer. ... So contrib/demo is the only one that needs the JAR. Yes, it would be enough. I'll revert and include the demo-contrib-specific build changes in LUCENE-2923 .
        Hide
        Robert Muir added a comment -

        Hi Uwe, I suggested this idea to Steven thinking it would be simpler.

        I didn't know it made the build a lot longer... but this is just the core jar and it sets the
        property that core.compiled=true... so if its really that much slower I am surprised?

        Show
        Robert Muir added a comment - Hi Uwe, I suggested this idea to Steven thinking it would be simpler. I didn't know it made the build a lot longer... but this is just the core jar and it sets the property that core.compiled=true... so if its really that much slower I am surprised?
        Hide
        Uwe Schindler added a comment - - edited

        Hi Steven,
        I was out of office when you committed this. I don't understand the reason why you add the JAR build to every contrib now? Would it be not enough to just extend "init" target in the demo contrib? This is easy possible (to override targets imported before using a "super." like construct). I spent a lot of time to remove the unneeded jar builds in Lucene contrib about one year ago, on my laptop the build now takes lot longer. All contrib builds are never using any jar file, their classpath's always use the file system folders during compiling and testing. This speeds up the build enormous (before my changes in up-to-date, every dependent contrib was always compiled as JAR). So contrib/demo is the only one that needs the JAR.

        Show
        Uwe Schindler added a comment - - edited Hi Steven, I was out of office when you committed this. I don't understand the reason why you add the JAR build to every contrib now? Would it be not enough to just extend "init" target in the demo contrib? This is easy possible (to override targets imported before using a "super." like construct). I spent a lot of time to remove the unneeded jar builds in Lucene contrib about one year ago, on my laptop the build now takes lot longer. All contrib builds are never using any jar file, their classpath's always use the file system folders during compiling and testing. This speeds up the build enormous (before my changes in up-to-date, every dependent contrib was always compiled as JAR). So contrib/demo is the only one that needs the JAR.
        Hide
        Steve Rowe added a comment -

        Committed: trunk rev. 1071891, branch_3x rev. 1071892

        Show
        Steve Rowe added a comment - Committed: trunk rev. 1071891, branch_3x rev. 1071892
        Hide
        Steve Rowe added a comment -

        Previous version of the patch had extraneous changes in lucene/contrib/contrib-build.xml - cleaned up in this version.

        Committing shortly.

        Show
        Steve Rowe added a comment - Previous version of the patch had extraneous changes in lucene/contrib/contrib-build.xml - cleaned up in this version. Committing shortly.
        Hide
        Steve Rowe added a comment -

        I'll commit later tonight unless there are objections.

        Show
        Steve Rowe added a comment - I'll commit later tonight unless there are objections.
        Hide
        Steve Rowe added a comment - - edited

        This patch causes the init target in contrib-build.xml to create the lucene-core jar if it doesn't exist or if it's out of date (lucene/src/java/**/*.java newer than the jar file).

        Without the patch, ant build-contrib from lucene/ takes 35 seconds (best of 3); with the patch, it takes 50 seconds (best of 3). I think this is negligable.

        Show
        Steve Rowe added a comment - - edited This patch causes the init target in contrib-build.xml to create the lucene-core jar if it doesn't exist or if it's out of date ( lucene/src/java/**/*.java newer than the jar file). Without the patch, ant build-contrib from lucene/ takes 35 seconds (best of 3); with the patch, it takes 50 seconds (best of 3). I think this is negligable.

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development