Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2912

remove field param from computeNorm, scorePayload ; remove UOE'd lengthNorm, switch SweetSpot to per-field

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0-ALPHA
    • None
    • None
    • New, Patch Available

    Description

      In LUCENE-2236 we switched sim to per field (SimilarityProvider returns a per-field similarity).

      But we didn't completely cleanup there... I think we should now do this:

      • SweetSpotSimilarity loses all its hashmaps. Instead, just configure one per field and return it in your SimilarityProvider. this means for example, all its TF factors can now be configured per-field too, not just the length normalization factors.
      • computeNorm and scorePayload lose their field parameter, as its redundant and confusing.
      • the UOE'd obselete lengthNorm is removed. I also updated javadocs that were pointing to it (this is bad!).

      Attachments

        1. LUCENE-2912.patch
          35 kB
          Robert Muir

        Activity

          People

            rcmuir Robert Muir
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: