Lucene - Core
  1. Lucene - Core
  2. LUCENE-2912

remove field param from computeNorm, scorePayload ; remove UOE'd lengthNorm, switch SweetSpot to per-field

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      In LUCENE-2236 we switched sim to per field (SimilarityProvider returns a per-field similarity).

      But we didn't completely cleanup there... I think we should now do this:

      • SweetSpotSimilarity loses all its hashmaps. Instead, just configure one per field and return it in your SimilarityProvider. this means for example, all its TF factors can now be configured per-field too, not just the length normalization factors.
      • computeNorm and scorePayload lose their field parameter, as its redundant and confusing.
      • the UOE'd obselete lengthNorm is removed. I also updated javadocs that were pointing to it (this is bad!).

        Activity

        Robert Muir created issue -
        Hide
        Robert Muir added a comment -

        Attached is an initial patch, all tests pass.

        Show
        Robert Muir added a comment - Attached is an initial patch, all tests pass.
        Robert Muir made changes -
        Field Original Value New Value
        Attachment LUCENE-2912.patch [ 12470704 ]
        Hide
        Robert Muir added a comment -

        Committed revision 1069980.

        Show
        Robert Muir added a comment - Committed revision 1069980.
        Robert Muir made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Robert Muir [ rcmuir ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12545065 ] Default workflow, editable Closed status [ 12562249 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12562249 ] jira [ 12583256 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2d 4h 23m 1 Robert Muir 11/Feb/11 23:16
        Resolved Resolved Closed Closed
        818d 11h 26m 1 Uwe Schindler 10/May/13 10:43

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development