Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: core/queryparser
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Note: this patch changes no behavior, just makes QP more subclassable.

      Currently we have Query getFieldQuery(String field, String queryText, boolean quoted)
      This contains very hairy methods for producing a query from QP's analyzer.

      I propose we factor this into newFieldQuery(Analyzer analyzer, String field, String queryText, boolean quoted)
      Then getFieldQuery just calls newFieldQuery(this.analyzer, field, queryText, quoted);

      The reasoning is: it can be quite useful to consider the double quote as more than phrases, but a "more exact" search.
      In the case the user quoted the terms, you might want to analyze the text with an alternate analyzer that:
      doesn't produce synonyms, doesnt decompose compounds, doesn't use WordDelimiterFilter
      (you would need to be using preserveOriginal=true at index time for the WDF one), etc etc.

      This is similar to the way google's double quote operator works, its not defined as phrase but "this exact wording or phrase".
      For example compare results to a query of tests versus "tests".

      Currently you can do this without heavy code duplication, but really only if you make a separate field (which is wasteful),
      and make your custom QP lie about its field... in the examples I listed above you can do this with a single field, yet still
      have a more exact phrase search.

        Activity

        Hide
        Robert Muir added a comment -

        I think this is an easy win for some common use cases from the API perspective.

        If no one objects i'll commit in a few days.

        Show
        Robert Muir added a comment - I think this is an easy win for some common use cases from the API perspective. If no one objects i'll commit in a few days.
        Hide
        Robert Muir added a comment -

        Committed revision 1069977.

        Show
        Robert Muir added a comment - Committed revision 1069977.

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development