Lucene - Core
  1. Lucene - Core
  2. LUCENE-2882

Cut over SpanQuery#getSpans to AtomicReaderContext

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Followup from LUCENE-2831 - SpanQuery#getSpans(IR) seems to be the last remaining artifact that doesn't enforce per-segments context while it should really work on AtomicReaderContext (SpanQuery#getSpans(AtomicReaderContext) instead of a naked IR.

      1. LUCENE-2882.patch
        66 kB
        Simon Willnauer
      2. LUCENE-2882.patch
        62 kB
        Simon Willnauer

        Issue Links

          Activity

          Hide
          Simon Willnauer added a comment -

          here is a patch that cuts over to ARC and cleans up some of the tests to perform span operations per segment

          Show
          Simon Willnauer added a comment - here is a patch that cuts over to ARC and cleans up some of the tests to perform span operations per segment
          Hide
          Robert Muir added a comment -

          looks good to me, thanks for splitting up the cleanup work from the other patch, good idea.

          Show
          Robert Muir added a comment - looks good to me, thanks for splitting up the cleanup work from the other patch, good idea.
          Hide
          Simon Willnauer added a comment -

          Seems like this is an easy one - I will commit shortly

          Show
          Simon Willnauer added a comment - Seems like this is an easy one - I will commit shortly
          Hide
          Simon Willnauer added a comment -

          some more cleanups and CHANGES.TXT entry... will commit in a minute

          Show
          Simon Willnauer added a comment - some more cleanups and CHANGES.TXT entry... will commit in a minute
          Hide
          Simon Willnauer added a comment -

          Committed revision 1062775.

          Show
          Simon Willnauer added a comment - Committed revision 1062775.

            People

            • Assignee:
              Simon Willnauer
              Reporter:
              Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development