Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2828

SimilarityDelegator broke back-compat for subclasses overriding lengthNorm

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 3.0.3
    • 2.9.5, 3.0.4
    • None
    • None
    • New

    Description

      In LUCENE-1420, we added Similarity.computeNorm to let the norm computation have access to the raw information (length, boost, etc.).

      But this class broke back compat with SimilarityDelegator. We did add computeNorm there, but, it's impl just forwards to the delegee's computeNorm. In the case where a subclass of SimilarityDelegator overrides lengthNorm, that method will no longer be invoked.

      Not quite sure how to fix this since, somehow, we have to determine whether the delegee's impl of computeNorm should be favored over the subclasses impl of the "legacy" lengthNorm.

      Attachments

        1. LUCENE-2828.patch
          1 kB
          Michael McCandless

        Activity

          People

            rcmuir Robert Muir
            mikemccand Michael McCandless
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: