[LUCENE-2805] SegmentInfos shouldn't blindly increment version on commit

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1, 4.0-ALPHA
• Component/s: core/index
• Lucene Fields: New
• Assignee: Simon Willnauer
• Reporter: Michael McCandless
• Created: 07/Dec/10 00:44
• Updated: 28/Aug/22 12:37
• Resolved: 08/Dec/10 13:27

Description

SegmentInfos currently increments version on the assumption that there are always changes.

But, both DirReader and IW are more careful about tracking whether there are changes. DirReader has hasChanges and IW has changeCount. I think these classes should notify the SIS when there are in fact changes; this will fix the case Simon hit on fixing LUCENE-2082 when the NRT reader thought there were changes, but in fact there weren't because IW simply committed the exact SIS it already had.

Issue Links

• blocks: LUCENE-2802 DirectoryReader ignores NRT SegmentInfos in #isOptimized()