Lucene - Core
  1. Lucene - Core
  2. LUCENE-2803

FieldCache should not pay attention to deleted docs when creating entries

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The FieldCache uses a key that ignores deleted docs, so it's actually a bug to use deleted docs when creating an entry. It can lead to incorrect values when the same entry is used with a different reader.

        Activity

        Hide
        Yonik Seeley added a comment -

        Here's the patch... pretty simple, so I plan on committing shortly.

        Show
        Yonik Seeley added a comment - Here's the patch... pretty simple, so I plan on committing shortly.
        Hide
        Ryan McKinley added a comment -

        if checkMatchAllBits always has a null first parameter, should we just take it out?

        Show
        Ryan McKinley added a comment - if checkMatchAllBits always has a null first parameter, should we just take it out?
        Hide
        Yonik Seeley added a comment -

        if checkMatchAllBits always has a null first parameter, should we just take it out?

        done.

        Show
        Yonik Seeley added a comment - if checkMatchAllBits always has a null first parameter, should we just take it out? done.
        Hide
        Yonik Seeley added a comment -

        committed. I'm not super happy with the verbiage in CHANGES.txt, so please feel free to improve.

        Note: this is also a problem in 2.9 and 3.x, but any fix would be much more difficult since deleted docs are screened out at a very low level int he APIs.

        Show
        Yonik Seeley added a comment - committed. I'm not super happy with the verbiage in CHANGES.txt, so please feel free to improve. Note: this is also a problem in 2.9 and 3.x, but any fix would be much more difficult since deleted docs are screened out at a very low level int he APIs.

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development