[LUCENE-2802] DirectoryReader ignores NRT SegmentInfos in #isOptimized()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1, 4.0-ALPHA
• Fix Version/s: 3.1, 4.0-ALPHA
• Component/s: core/search
• Lucene Fields: New
• Assignee: Simon Willnauer
• Reporter: Simon Willnauer
• Created: 06/Dec/10 13:39
• Updated: 28/Aug/22 12:37
• Resolved: 08/Dec/10 13:49

Description

DirectoryReader only takes shared (with IW) SegmentInfos into account in DirectoryReader#isOptimized(). This can return true even if the actual realtime reader sees more than one segments.

public boolean isOptimized() {
    ensureOpen();
   // if segmentsInfos changes in IW this can return false positive
    return segmentInfos.size() == 1 && !hasDeletions();
  }

DirectoryReader should check if this reader has a non-nul segmentInfosStart and use that instead

Issue Links

• is blocked by: LUCENE-2805 SegmentInfos shouldn't blindly increment version on commit
• is related to: LUCENE-2355 Refactor Directory/Multi/SegmentReader creation/reopening/cloning/closing