Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2793

Directory createOutput and openInput should take an IOContext

    Details

    • Lucene Fields:
      New, Patch Available

      Description

      Today for merging we pass down a larger readBufferSize than for searching because we get better performance.

      I think we should generalize this to a class (IOContext), which would hold the buffer size, but then could hold other flags like DIRECT (bypass OS's buffer cache), SEQUENTIAL, etc.

      Then, we can make the DirectIOLinuxDirectory fully usable because we would only use DIRECT/SEQUENTIAL during merging.

      This will require fixing how IW pools readers, so that a reader opened for merging is not then used for searching, and vice/versa. Really, it's only all the open file handles that need to be different – we could in theory share del docs, norms, etc, if that were somehow possible.

        Attachments

        1. LUCENE-2793.patch
          31 kB
          Jason Rutherglen
        2. LUCENE-2793.patch
          16 kB
          Varun Thacker
        3. LUCENE-2793.patch
          2 kB
          Varun Thacker
        4. LUCENE-2793.patch
          15 kB
          Varun Thacker
        5. LUCENE-2793.patch
          24 kB
          Varun Thacker
        6. LUCENE-2793.patch
          75 kB
          Varun Thacker
        7. LUCENE-2793.patch
          3 kB
          Varun Thacker
        8. LUCENE-2793.patch
          94 kB
          Varun Thacker
        9. LUCENE-2793.patch
          92 kB
          Varun Thacker
        10. LUCENE-2793.patch
          106 kB
          Varun Thacker
        11. LUCENE-2793.patch
          140 kB
          Varun Thacker
        12. LUCENE-2793.patch
          132 kB
          Varun Thacker
        13. LUCENE-2793.patch
          198 kB
          Varun Thacker
        14. LUCENE-2793.patch
          212 kB
          Varun Thacker
        15. LUCENE-2793.patch
          223 kB
          Varun Thacker
        16. LUCENE-2793.patch
          231 kB
          Simon Willnauer
        17. LUCENE-2793.patch
          51 kB
          Varun Thacker
        18. LUCENE-2793-nrt.patch
          4 kB
          Michael McCandless
        19. LUCENE-2793.patch
          180 kB
          Varun Thacker
        20. LUCENE-2793.patch
          180 kB
          Varun Thacker
        21. LUCENE-2793.patch
          10 kB
          Varun Thacker
        22. LUCENE-2793.patch
          9 kB
          Varun Thacker
        23. LUCENE-2793.patch
          8 kB
          Varun Thacker
        24. LUCENE-2793.patch
          17 kB
          Varun Thacker
        25. LUCENE-2793.patch
          8 kB
          Varun Thacker
        26. LUCENE-2793.patch
          17 kB
          Simon Willnauer
        27. LUCENE-2793.patch
          17 kB
          Simon Willnauer
        28. LUCENE-2793_final.patch
          315 kB
          Simon Willnauer

          Issue Links

            Activity

              People

              • Assignee:
                varunthacker Varun Thacker
                Reporter:
                mikemccand Michael McCandless
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: