Lucene - Core
  1. Lucene - Core
  2. LUCENE-2699

Update StandardTokenizer and UAX29Tokenizer to Unicode 6.0.0

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1, 4.0-ALPHA
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Newly released Unicode 6.0.0 contains some character property changes from the previous release (5.2.0) that affect word segmentation (UAX#29), and JFlex 1.5.0-SNAPSHOT now supports Unicode 6.0.0, so Lucene's UAX#29-based tokenizers should be updated accordingly.

      Note that the UAX#29 word break rules themselves did not change between Unicode versions 5.2.0 and 6.0.0.

      1. LUCENE-2699.patch
        590 kB
        Steve Rowe
      2. LUCENE-2699.patch
        590 kB
        Steve Rowe
      3. LUCENE-2699.patch
        590 kB
        Steve Rowe
      4. LUCENE-2699.patch
        588 kB
        Steve Rowe

        Activity

        Hide
        Steve Rowe added a comment -

        Patch upgrading UAX#29-based tokenizers to Unicode 6.0.0.

        Show
        Steve Rowe added a comment - Patch upgrading UAX#29-based tokenizers to Unicode 6.0.0.
        Hide
        Robert Muir added a comment -

        +1

        does the minimal jflex revision need to be bumped (currently r591 in READ_BEFORE_REGENERATING.txt) ?

        Show
        Robert Muir added a comment - +1 does the minimal jflex revision need to be bumped (currently r591 in READ_BEFORE_REGENERATING.txt) ?
        Hide
        Steve Rowe added a comment -

        Yes, it should be bumped to r597. I post a patch including that shortly. Thanks for the review, Robert.

        Show
        Steve Rowe added a comment - Yes, it should be bumped to r597. I post a patch including that shortly. Thanks for the review, Robert.
        Hide
        Steve Rowe added a comment -

        In this version of the patch, I bumped the minimum JFlex trunk revision in READ_BEFORE_REGENERATING.txt to 597. Also added a CHANGES.txt entry.

        Show
        Steve Rowe added a comment - In this version of the patch, I bumped the minimum JFlex trunk revision in READ_BEFORE_REGENERATING.txt to 597. Also added a CHANGES.txt entry.
        Hide
        Steve Rowe added a comment -

        This version of the patch fixes mixed end-of-lines present in the previous versions - I installed http://www.apache.org/dev/svn-eol-style.txt - thanks Robert!

        Show
        Steve Rowe added a comment - This version of the patch fixes mixed end-of-lines present in the previous versions - I installed http://www.apache.org/dev/svn-eol-style.txt - thanks Robert!
        Hide
        Steve Rowe added a comment -

        The previous patches were generated on WinVista under Cygwin using a native Windows client (SlikSVN) – apparently that isn't a good idea - mixed end-of-line styles run rampant (and rampant, whatever it is, can't be good).

        This version of the patch really doesn't have mixed end-of-line styles. I used the Cygwin svn client this time, and all end-of-lines are LF.

        I plan on committing shortly.

        Show
        Steve Rowe added a comment - The previous patches were generated on WinVista under Cygwin using a native Windows client (SlikSVN) – apparently that isn't a good idea - mixed end-of-line styles run rampant (and rampant, whatever it is, can't be good). This version of the patch really doesn't have mixed end-of-line styles. I used the Cygwin svn client this time, and all end-of-lines are LF. I plan on committing shortly.
        Hide
        Steve Rowe added a comment -

        Committed: trunk revision 1022826, branch_3x revision 1022831

        Show
        Steve Rowe added a comment - Committed: trunk revision 1022826, branch_3x revision 1022831
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development